-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-677: fix: allow deleting all storageclasses / vgs in case one is already gone #414
OCPVE-677: fix: allow deleting all storageclasses / vgs in case one is already gone #414
Conversation
@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f9799f6
to
2b1d98c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 55.01% 52.21% -2.81%
==========================================
Files 27 29 +2
Lines 2341 2848 +507
==========================================
+ Hits 1288 1487 +199
- Misses 965 1261 +296
- Partials 88 100 +12
|
/retest-required |
/test lvm-operator-e2e-aws |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Part of vgmanager refactor. For resourceManagers managing multiple resources, previously the delete aborted if one of the managed resources was not found. Now it properly continues until all resources are no longer found. This applies to LVMVolumeGroup, SCCs, VolumeSnapshotClass and StorageClass