-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-18354: chore: remove unnecessary labels from vg manager DaemonSet #412
OCPBUGS-18354: chore: remove unnecessary labels from vg manager DaemonSet #412
Conversation
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18354, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18354, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18354, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18354, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18354, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 55.01% 55.00% -0.02%
==========================================
Files 27 27
Lines 2341 2340 -1
==========================================
- Hits 1288 1287 -1
Misses 965 965
Partials 88 88
|
/test verify |
1 similar comment
/test verify |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test verify |
1 similar comment
/test verify |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jakobmoellerdev: Jira Issue OCPBUGS-18354: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18354 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This removes the 6 labels that were introduces as part of #405 for the vgmanager DaemonSet since it contains a normal ownerreference and doesnt need these labels. They were commited by accident. No legacy removal necessary since we never released a version for this change