Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-677: fix: allow deletion of lvmvolumegroup if lvmd conf was already deleted #409

Conversation

jakobmoellerdev
Copy link
Contributor

Part of the findings of testing vgmanager. This allows us to delete LVMVolumeGroups even if the lvmd.conf file was previously deleted. This can also happen in case the LVMVolumeGroup creation failed and we want to remove the LVMVolumeGroup. In this case, the lvmd.conf file never existed in the first place and it would previously stop the LVMVolumeGroup from being deleted. Now, whenever the lvmd.conf file is not found, we just skip the deletion of the lvmd.conf entry.

@jakobmoellerdev jakobmoellerdev changed the title fix: allow deletion of lvmvolumegroup if lvmd conf was already deleted OCPVE-677: fix: allow deletion of lvmvolumegroup if lvmd conf was already deleted Sep 8, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2023

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Part of the findings of testing vgmanager. This allows us to delete LVMVolumeGroups even if the lvmd.conf file was previously deleted. This can also happen in case the LVMVolumeGroup creation failed and we want to remove the LVMVolumeGroup. In this case, the lvmd.conf file never existed in the first place and it would previously stop the LVMVolumeGroup from being deleted. Now, whenever the lvmd.conf file is not found, we just skip the deletion of the lvmd.conf entry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2023
@openshift-ci openshift-ci bot requested review from jeff-roche and qJkee September 8, 2023 08:18
@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8da92ee and 2 for PR HEAD 949446b in total

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ceed42e and 1 for PR HEAD 949446b in total

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

2 similar comments
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3386fe2 into openshift:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants