-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-677: fix: allow deletion of lvmvolumegroup if lvmd conf was already deleted #409
OCPVE-677: fix: allow deletion of lvmvolumegroup if lvmd conf was already deleted #409
Conversation
@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test lvm-operator-e2e-aws |
/test lvm-operator-e2e-aws |
2 similar comments
/test lvm-operator-e2e-aws |
/test lvm-operator-e2e-aws |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Part of the findings of testing vgmanager. This allows us to delete LVMVolumeGroups even if the lvmd.conf file was previously deleted. This can also happen in case the LVMVolumeGroup creation failed and we want to remove the LVMVolumeGroup. In this case, the lvmd.conf file never existed in the first place and it would previously stop the LVMVolumeGroup from being deleted. Now, whenever the lvmd.conf file is not found, we just skip the deletion of the lvmd.conf entry.