OCPBUGS-17848: fix: don't fail if devices already in vg

[jeff-roche]

It was discovered as part of the 4.14 verification process that the available devices check was creating an error due to not properly skipping devices that were already part of the volume group. This error would lead to a degraded state of the lvmcluster when the first reconciliation loop was initiated.

[openshift-ci-robot]

@jeff-roche: This pull request references Jira Issue OCPBUGS-17848, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-roche]

/cc @suleymanakbas91 @jakobmoellerdev

[openshift-ci-robot]

@jeff-roche: This pull request references Jira Issue OCPBUGS-17848, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

It was discovered as part of the 4.14 verification process that the available devices check was creating an error due to not properly skipping devices that were already part of the volume group. This error would lead to a degraded state of the lvmcluster when the first reconciliation loop was initiated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-roche]

/jira refresh

[openshift-ci-robot]

@jeff-roche: This pull request references Jira Issue OCPBUGS-17848, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jeff-roche]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jeff-roche]

/retest

[openshift-ci]

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jeff-roche: Jira Issue OCPBUGS-17848: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#387

Jira Issue OCPBUGS-17848 has been moved to the MODIFIED state.

In response to this:

It was discovered as part of the 4.14 verification process that the available devices check was creating an error due to not properly skipping devices that were already part of the volume group. This error would lead to a degraded state of the lvmcluster when the first reconciliation loop was initiated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-roche]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@jeff-roche: #387 failed to apply on top of branch "release-4.14":

Applying: fix: don't fail if devices already in vg
Using index info to reconstruct a base tree...
M	pkg/vgmanager/devices.go
M	pkg/vgmanager/devices_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/vgmanager/devices_test.go
Auto-merging pkg/vgmanager/devices.go
CONFLICT (content): Merge conflict in pkg/vgmanager/devices.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: don't fail if devices already in vg
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-roche]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@jeff-roche: new pull request created: #397

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.