Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-404: chore: adding some local helper scripts and makefile updates #362

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

jeff-roche
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2023
@openshift-ci openshift-ci bot requested review from qJkee and suleymanakbas91 July 12, 2023 13:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@jeff-roche jeff-roche changed the title chore: adding some local helper scripts and makefile updates [WIP] chore: adding some local helper scripts and makefile updates Jul 12, 2023
@jeff-roche
Copy link
Contributor Author

/hold wip

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 12, 2023
@jeff-roche
Copy link
Contributor Author

/unhold

@jeff-roche jeff-roche changed the title [WIP] chore: adding some local helper scripts and makefile updates chore: adding some local helper scripts and makefile updates Jul 12, 2023
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 12, 2023
@jeff-roche jeff-roche changed the title chore: adding some local helper scripts and makefile updates OCPVE-404: chore: adding some local helper scripts and makefile updates Jul 12, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2023

@jeff-roche: This pull request references OCPVE-404 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Makefile Outdated Show resolved Hide resolved
@qJkee
Copy link
Contributor

qJkee commented Jul 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #362 (5efb22b) into main (ddcc1b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   14.47%   14.47%           
=======================================
  Files          23       23           
  Lines        1920     1920           
=======================================
  Hits          278      278           
  Misses       1618     1618           
  Partials       24       24           

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ddcc1b5 and 2 for PR HEAD 5efb22b in total

@jeff-roche
Copy link
Contributor Author

e2e tests are broken in general. This is the first step towards getting things fixed
/override ci/prow/lvm-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

@jeff-roche: Overrode contexts on behalf of jeff-roche: ci/prow/lvm-operator-bundle-e2e-aws

In response to this:

e2e tests are broken in general. This is the first step towards getting things fixed
/override ci/prow/lvm-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche jeff-roche merged commit d4aed7c into openshift:main Jul 12, 2023
@jeff-roche jeff-roche deleted the local-helpers branch July 12, 2023 18:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants