Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-380: feat: rhel 9 and accompanying changes #361

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

jeff-roche
Copy link
Contributor

@jeff-roche jeff-roche commented Jun 28, 2023

This updates the github dockerfile and updates the lsblk parser to handle boolean field changes

CPaaS changes will follow after the 4.14 branch is configured

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2023
@jeff-roche jeff-roche changed the title feat: rhel 9 and accompanying changes OCPVE-380: feat: rhel 9 and accompanying changes Jun 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023

@jeff-roche: This pull request references OCPVE-380 which is a valid jira issue.

In response to this:

This updates the github dockerfile and updates the lsblk parser to handle boolean field changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci openshift-ci bot requested review from brandisher and qJkee June 28, 2023 14:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023

@jeff-roche: This pull request references OCPVE-380 which is a valid jira issue.

In response to this:

This updates the github dockerfile and updates the lsblk parser to handle boolean field changes

CPaaS changes will follow after the 4.14 branch is configured

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #361 (7937eb4) into main (e367532) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   14.52%   14.47%   -0.05%     
==========================================
  Files          23       23              
  Lines        1921     1920       -1     
==========================================
- Hits          279      278       -1     
  Misses       1618     1618              
  Partials       24       24              
Impacted Files Coverage Δ
pkg/vgmanager/filter.go 78.94% <100.00%> (-0.54%) ⬇️

@brandisher
Copy link
Contributor

/lgtm
/hold

Looks good to me; holding for @qJkee's final review.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@jeff-roche
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@jeff-roche
Copy link
Contributor Author

/retest

@qJkee
Copy link
Contributor

qJkee commented Jun 30, 2023

/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@jeff-roche
Copy link
Contributor Author

Manual run of the e2e tests yields a passing result, not sure why CI is hiccuping

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e367532 and 2 for PR HEAD 7937eb4 in total

@jeff-roche
Copy link
Contributor Author

I believe the e2e tests are an expected failure in CI in this situation. I've run the e2e tests multiple times manually with successful results. I'm going to override the failure here as I believe it is an unrelated CI issue.

/override ci/prow/lvm-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

@jeff-roche: Overrode contexts on behalf of jeff-roche: ci/prow/lvm-operator-bundle-e2e-aws

In response to this:

I believe the e2e tests are an expected failure in CI in this situation. I've run the e2e tests multiple times manually with successful results. I'm going to override the failure here as I believe it is an unrelated CI issue.

/override ci/prow/lvm-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche jeff-roche merged commit ddcc1b5 into openshift:main Jun 30, 2023
@jeff-roche jeff-roche deleted the lvms-rhel9 branch June 30, 2023 15:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants