-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-380: feat: rhel 9 and accompanying changes #361
Conversation
@jeff-roche: This pull request references OCPVE-380 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeff-roche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jeff-roche: This pull request references OCPVE-380 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
- Coverage 14.52% 14.47% -0.05%
==========================================
Files 23 23
Lines 1921 1920 -1
==========================================
- Hits 279 278 -1
Misses 1618 1618
Partials 24 24
|
/lgtm Looks good to me; holding for @qJkee's final review. |
/retest |
/retest |
/unhold |
Manual run of the e2e tests yields a passing result, not sure why CI is hiccuping |
I believe the e2e tests are an expected failure in CI in this situation. I've run the e2e tests multiple times manually with successful results. I'm going to override the failure here as I believe it is an unrelated CI issue. /override ci/prow/lvm-operator-bundle-e2e-aws |
@jeff-roche: Overrode contexts on behalf of jeff-roche: ci/prow/lvm-operator-bundle-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jeff-roche: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This updates the github dockerfile and updates the
lsblk
parser to handle boolean field changesCPaaS changes will follow after the 4.14 branch is configured