Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-302: feat: fstype e2e tests #357

Merged
merged 1 commit into from
Jun 9, 2023
Merged

OCPVE-302: feat: fstype e2e tests #357

merged 1 commit into from
Jun 9, 2023

Conversation

jeff-roche
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@jeff-roche jeff-roche changed the title draft: chore: reformatted the e2e test grouping to not force cluster setup chore: reformatted the e2e test grouping to not force cluster setup Jun 2, 2023
@jeff-roche
Copy link
Contributor Author

/hold for more changes

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@jeff-roche jeff-roche marked this pull request as draft June 2, 2023 12:32
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2023
@jeff-roche jeff-roche changed the title chore: reformatted the e2e test grouping to not force cluster setup OCPVE-302: feat: fstype e2e tests Jun 8, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2023 •
edited by openshift-ci bot
Loading

@jeff-roche: This pull request references OCPVE-302 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche jeff-roche marked this pull request as ready for review June 8, 2023 18:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2023
@openshift-ci openshift-ci bot requested a review from qJkee June 8, 2023 18:14
@codecov-commenter
Copy link

Codecov Report

Merging #357 (bde9fe4) into main (00c61db) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   14.52%   14.52%           
=======================================
  Files          23       23           
  Lines        1921     1921           
=======================================
  Hits          279      279           
  Misses       1618     1618           
  Partials       24       24

@brandisher
Copy link
Contributor

One minor question but looks good otherwise. Holding for @qJkee's review.

/lgtm
/hold

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
qJkee
qJkee reviewed Jun 9, 2023
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@jeff-roche
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2023

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brandisher
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit e367532 into openshift:main Jun 9, 2023
@jeff-roche jeff-roche deleted the ext4-e2e branch June 9, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandisher brandisher brandisher left review comments

@qJkee qJkee qJkee left review comments

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@suleymanakbas91 suleymanakbas91 Awaiting requested review from suleymanakbas91

Assignees

@brandisher brandisher

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeff-roche @openshift-ci-robot @codecov-commenter @brandisher @qJkee @openshift-merge-robot