-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-349: Add PV and PVC controllers to publish events #356
OCPVE-349: Add PV and PVC controllers to publish events #356
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
35455db
to
4ab4bd5
Compare
22ee048
to
a20ac8e
Compare
a20ac8e
to
ad91638
Compare
@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ad91638
to
f297514
Compare
053df2b
to
354a1f3
Compare
/hold for more testing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 14.52% 14.52%
=======================================
Files 23 23
Lines 1921 1921
=======================================
Hits 279 279
Misses 1618 1618
Partials 24 24
|
354a1f3
to
3deee74
Compare
Signed-off-by: Suleyman Akbas <[email protected]>
3deee74
to
4a39afc
Compare
@suleymanakbas91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Couple of questions/nits but lgtm. Keeping the hold on so @jeff-roche can take a look as well. /lgtm |
@jeff-roche was only waiting for the claimRef test before giving his approval, so I think it should be ok to unhold it now. /unhold |
@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds a PV and a PVC controller to the LVM Operator.
The PV controller watches for PVs created by LVMS and publishes an event if their
spec.claimRef
gets deleted:The PVC controller watches for the PVCs created by LVMS and publishes an event if the PVC requests a storage greater than available capacity on any node: