Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-349: Add PV and PVC controllers to publish events #356

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented May 31, 2023

This PR adds a PV and a PVC controller to the LVM Operator.

  • The PV controller watches for PVs created by LVMS and publishes an event if their spec.claimRef gets deleted:

    Screenshot 2023-06-01 at 16 26 41
  • The PVC controller watches for the PVCs created by LVMS and publishes an event if the PVC requests a storage greater than available capacity on any node:

    Screenshot 2023-06-06 at 12 22 11

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@suleymanakbas91 suleymanakbas91 force-pushed the new-controllers branch 2 times, most recently from 35455db to 4ab4bd5 Compare May 31, 2023 13:30
@suleymanakbas91 suleymanakbas91 force-pushed the new-controllers branch 5 times, most recently from 22ee048 to a20ac8e Compare June 1, 2023 13:58
@suleymanakbas91 suleymanakbas91 marked this pull request as ready for review June 1, 2023 14:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2023
@suleymanakbas91 suleymanakbas91 changed the title feat: add pv and pvc controllers to publish events OCPVE-349: Add pv and pvc controllers to publish events Jun 1, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023

@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue.

In response to this:

This PR adds a PV and a PVC controller to the LVM Operator.

  • The PV controller watches for PVs created by LVMS and publishes an event if their spec.claimRef gets deleted:
Screenshot 2023-06-01 at 16 26 41
  • The PVC controller watches for the PVCs created by LVMS and publishes an event if the PVC requests a storage greater than capacities of all the nodes:
Screenshot 2023-06-01 at 16 27 34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91 suleymanakbas91 changed the title OCPVE-349: Add pv and pvc controllers to publish events OCPVE-349: Add PV and PVC controllers to publish events Jun 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023

@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue.

In response to this:

This PR adds a PV and a PVC controller to the LVM Operator.

  • The PV controller watches for PVs created by LVMS and publishes an event if their spec.claimRef gets deleted:
Screenshot 2023-06-01 at 16 26 41
  • The PVC controller watches for the PVCs created by LVMS and publishes an event if the PVC requests a storage greater than capacity on any node:
Screenshot 2023-06-01 at 16 27 34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023

@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue.

In response to this:

This PR adds a PV and a PVC controller to the LVM Operator.

  • The PV controller watches for PVs created by LVMS and publishes an event if their spec.claimRef gets deleted:
Screenshot 2023-06-01 at 16 26 41
  • The PVC controller watches for the PVCs created by LVMS and publishes an event if the PVC requests a storage greater than available capacity on any node:
Screenshot 2023-06-01 at 16 27 34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from brandisher and jeff-roche June 1, 2023 14:37
@suleymanakbas91 suleymanakbas91 force-pushed the new-controllers branch 2 times, most recently from 053df2b to 354a1f3 Compare June 1, 2023 16:19
@suleymanakbas91
Copy link
Contributor Author

/hold for more testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #356 (3deee74) into main (00c61db) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   14.52%   14.52%           
=======================================
  Files          23       23           
  Lines        1921     1921           
=======================================
  Hits          279      279           
  Misses       1618     1618           
  Partials       24       24           
Impacted Files Coverage Δ
controllers/lvmcluster_controller.go 0.00% <0.00%> (ø)
controllers/utils.go 40.00% <0.00%> (ø)
pkg/vgmanager/vgmanager_controller.go 0.00% <0.00%> (ø)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brandisher
Copy link
Contributor

Couple of questions/nits but lgtm. Keeping the hold on so @jeff-roche can take a look as well.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@suleymanakbas91
Copy link
Contributor Author

@jeff-roche was only waiting for the claimRef test before giving his approval, so I think it should be ok to unhold it now.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2023

@suleymanakbas91: This pull request references OCPVE-349 which is a valid jira issue.

In response to this:

This PR adds a PV and a PVC controller to the LVM Operator.

  • The PV controller watches for PVs created by LVMS and publishes an event if their spec.claimRef gets deleted:
Screenshot 2023-06-01 at 16 26 41
  • The PVC controller watches for the PVCs created by LVMS and publishes an event if the PVC requests a storage greater than available capacity on any node:
Screenshot 2023-06-06 at 12 22 11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91 suleymanakbas91 merged commit a81b6aa into openshift:main Jun 6, 2023
@suleymanakbas91 suleymanakbas91 deleted the new-controllers branch June 6, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants