Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-308: Convert todos to jiras #353

Merged
merged 5 commits into from
May 30, 2023
Merged

OCPVE-308: Convert todos to jiras #353

merged 5 commits into from
May 30, 2023

Conversation

brandisher
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2023
@brandisher brandisher force-pushed the convert-todos-to-jiras branch from 679157f to 8b1e23b Compare May 26, 2023 19:33
@brandisher brandisher marked this pull request as ready for review May 26, 2023 19:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2023
@openshift-ci openshift-ci bot requested a review from jerpeter1 May 26, 2023 19:45
@brandisher brandisher changed the title Convert todos to jiras OCPVE-282: Convert todos to jiras May 26, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2023
@brandisher brandisher changed the title OCPVE-282: Convert todos to jiras OCPVE-308: Convert todos to jiras May 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 26, 2023 •
edited by openshift-ci bot
Loading

@brandisher: This pull request references OCPVE-308 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift openshift deleted a comment from openshift-ci-robot May 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023 •
edited
Loading

Codecov Report

Merging #353 (7f96143) into main (6daa5fb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   14.52%   14.52%           
=======================================
  Files          23       23           
  Lines        1921     1921           
=======================================
  Hits          279      279           
  Misses       1618     1618           
  Partials       24       24
Impacted Files Coverage Δ
api/v1alpha1/lvmcluster_types.go 100.00% <ø> (ø)
api/v1alpha1/lvmvolumegroup_types.go 100.00% <ø> (ø)
controllers/lvmcluster_controller.go 0.00% <ø> (ø)
controllers/topolvm_controller.go 0.00% <ø> (ø)
pkg/vgmanager/lvm.go 47.96% <ø> (ø)

suleymanakbas91
suleymanakbas91 requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please retitle the commits in the format "cleanup: title"? 🙂

@brandisher brandisher force-pushed the convert-todos-to-jiras branch from 36ed40b to f8aaf44 Compare May 26, 2023 20:09
@suleymanakbas91
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brandisher, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brandisher,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0c57987 and 2 for PR HEAD f8aaf44 in total

@suleymanakbas91
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e325b7d and 1 for PR HEAD f8aaf44 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2023
brandisher added 3 commits May 30, 2023 08:42
@brandisher
cleanup: remove golanglintci todo
5e4086e 
This TODO is dependent on a change in golangci-lint-action which hasn't
seen any action since before April 2022. Safe to assume this won't be
completed and leaving the --skip-files flag is a noop.
@brandisher
cleanup: remove lvm config todo
967edb8 
We agreed that we would not implement low-level lvm config into the
operator because it introduced too many iterations of test scenarios
that would need to be covered. We'll instead adjust the API to fit
specific scenarios on an as-needed basis.
@brandisher
cleanup: remove lvmcluseter_controller todo
00eb884 
Covered by https://issues.redhat.com/browse/OCPVE-348
@brandisher brandisher force-pushed the convert-todos-to-jiras branch from f8aaf44 to 7f96143 Compare May 30, 2023 12:43
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@brandisher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91 suleymanakbas91 merged commit cd91081 into openshift:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-roche jeff-roche Awaiting requested review from jeff-roche

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@suleymanakbas91 suleymanakbas91 Awaiting requested review from suleymanakbas91

Assignees

@suleymanakbas91 suleymanakbas91

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brandisher @openshift-ci-robot @codecov-commenter @suleymanakbas91 @openshift-merge-robot