Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-333: check create or update functions #352

Merged
merged 3 commits into from
May 30, 2023

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented May 26, 2023

Check create or update functions and refactor code a little bit =)
PART 1

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 26, 2023
@openshift-ci openshift-ci bot requested review from brandisher and jerpeter1 May 26, 2023 13:40
@qJkee
Copy link
Contributor Author

qJkee commented May 26, 2023

/cc @suleymanakbas91 @jeff-roche

@jeff-roche jeff-roche changed the title [OCPVE]-333 check create or update functions OCPVE-333: check create or update functions May 26, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 26, 2023

@qJkee: This pull request references OCPVE-333 which is a valid jira issue.

In response to this:

Check create or update functions and refactor code a little bit =)
PART 1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@suleymanakbas91
Copy link
Contributor

/hold I'd like to take a look 🙂

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@suleymanakbas91
Copy link
Contributor

Looking great! Thanks @qJkee!
/unhold

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #352 (f9e643e) into main (0c57987) will increase coverage by 1.30%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   11.77%   13.08%   +1.30%     
==========================================
  Files          21       23       +2     
  Lines        1843     2148     +305     
==========================================
+ Hits          217      281      +64     
- Misses       1606     1843     +237     
- Partials       20       24       +4     
Impacted Files Coverage Δ
controllers/lvm_volumegroup.go 0.00% <0.00%> (ø)
controllers/topolvm_controller.go 0.00% <0.00%> (ø)
controllers/topolvm_csi_driver.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f2ed6a0 into openshift:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants