Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-337: Add an architecture diagram #341

Merged
merged 1 commit into from
May 16, 2023

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented May 11, 2023

This PR adds an architecture diagram to the docs.

@suleymanakbas91 suleymanakbas91 changed the title docs: add an architecture diagram OCPVE-337: Add an architecture diagram May 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 11, 2023

@suleymanakbas91: This pull request references OCPVE-337 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 11, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 11, 2023

@suleymanakbas91: This pull request references OCPVE-337 which is a valid jira issue.

In response to this:

This PR adds an architecture diagram to the docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from brandisher and qJkee May 11, 2023 12:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@suleymanakbas91 suleymanakbas91 force-pushed the arch branch 3 times, most recently from d5fd63c to e5c03a9 Compare May 11, 2023 12:40
Copy link

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! left a few small comments :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/design/architecture.md Outdated Show resolved Hide resolved
docs/design/architecture.md Outdated Show resolved Hide resolved
docs/design/lvm-operator-manager.md Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qJkee
Copy link
Contributor

qJkee commented May 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit f134b28 into openshift:main May 16, 2023
@suleymanakbas91 suleymanakbas91 deleted the arch branch May 16, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants