feat: add mutate function #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leelavg
reviewed
Dec 21, 2021
|
Forgot to mention earlier, we need to assign containers spec as well in mutate function. |
nbalacha
reviewed
Dec 21, 2021
Implement the mutate function content for the createorUpdate topolvmdNode resource. Signed-off-by: Juan Miguel Olmo Martínez <[email protected]>
sp98
approved these changes
Dec 21, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmolmo, sp98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nbalacha
reviewed
Dec 21, 2021
| ds.Spec.Template.Spec.Tolerations = dsTemplate.Spec.Template.Spec.Tolerations | ||
|
|
||
| // nodeSelector if non-nil | ||
| if dsTemplate.Spec.Template.Spec.Affinity != nil { |
There was a problem hiding this comment.
This needs to updated even if it is non-nil. We can change the nodeselector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the mutate function content for the createorUpdate topolvmdNode
resource.
Signed-off-by: Juan Miguel Olmo Martínez [email protected]