OCPBUGS-10534: Refactor status reporting logic to send updates more often

[suleymanakbas91]

This PR refactors status reporting logic to send updates more often.

• api/v1alpha1/lvmvolumegroupnodestatus_types.go: Adds a new Progressing status to volume groups.
• cmd/vgmanager/main.go: Minor fixes and cleanup.
• controllers/lvmcluster_controller.go: Modifies LVMCluster to report Ready only when all the volume groups are ready.
• pkg/vgmanager/devices.go: Moves finding available devices logic into a separate file.
• pkg/vgmanager/devices_test.go: Adds a unit test.
• pkg/vgmanager/status.go: Implements functions for volume group status calculation and setting.
• pkg/vgmanager/vgmanager_controller.go: Adds status updates for each failure and success.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[suleymanakbas91]

/test all

[codecov-commenter]

Codecov Report

Merging #339 (2529f3b) into main (c54c93e) will decrease coverage by 2.53%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   57.10%   54.58%   -2.53%     
==========================================
  Files          21       23       +2     
  Lines        1844     1920      +76     
==========================================
- Hits         1053     1048       -5     
- Misses        714      794      +80     
- Partials       77       78       +1     

Impacted Files	Coverage Δ
pkg/vgmanager/devices.go	0.00% <0.00%> (ø)
pkg/vgmanager/status.go	0.00% <0.00%> (ø)
pkg/vgmanager/vgmanager_controller.go	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

[openshift-ci]

@codecov-commenter: user codecov-commenter is not trusted for pull request #339

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-10534, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-10534, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

This PR refactors status reporting logic to send updates more often.

• api/v1alpha1/lvmvolumegroupnodestatus_types.go: Adds a new Progressing status to volume groups.
• cmd/vgmanager/main.go: Minor fixes and cleanup.
• controllers/lvmcluster_controller.go: Modifies LVMCluster to report Ready only when all the volume groups are ready.
• pkg/vgmanager/devices.go: Moves finding available devices logic into a separate file.
• pkg/vgmanager/devices_test.go: Adds a unit test.
• pkg/vgmanager/status.go: Implements functions for volume group status calculation and setting.
• pkg/vgmanager/vgmanager_controller.go: Adds status updates for each failure and success.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[suleymanakbas91]

/retest

[jeff-roche]

/lgtm

[suleymanakbas91]

/unhold

[jeff-roche]

/lgtm

[jeff-roche]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0c57987 and 2 for PR HEAD 7c72a67 in total

[suleymanakbas91]

/retest

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@suleymanakbas91: Jira Issue OCPBUGS-10534: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#339

Jira Issue OCPBUGS-10534 has been moved to the MODIFIED state.

In response to this:

This PR refactors status reporting logic to send updates more often.

• api/v1alpha1/lvmvolumegroupnodestatus_types.go: Adds a new Progressing status to volume groups.
• cmd/vgmanager/main.go: Minor fixes and cleanup.
• controllers/lvmcluster_controller.go: Modifies LVMCluster to report Ready only when all the volume groups are ready.
• pkg/vgmanager/devices.go: Moves finding available devices logic into a separate file.
• pkg/vgmanager/devices_test.go: Adds a unit test.
• pkg/vgmanager/status.go: Implements functions for volume group status calculation and setting.
• pkg/vgmanager/vgmanager_controller.go: Adds status updates for each failure and success.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.