Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-309: Remove commented code #337

Merged
merged 4 commits into from
May 17, 2023

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented May 5, 2023

Removed commented code
Bumped ginkgo and controller-runtime

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2023
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 5, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #337 (8e728ed) into main (166b452) will decrease coverage by 35.31%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #337       +/-   ##
===========================================
- Coverage   46.95%   11.65%   -35.31%     
===========================================
  Files          22       21        -1     
  Lines        2232     1828      -404     
===========================================
- Hits         1048      213      -835     
- Misses       1106     1595      +489     
+ Partials       78       20       -58     
Impacted Files Coverage Δ
controllers/lvm_volumegroup.go 0.00% <ø> (-75.31%) ⬇️
controllers/lvmcluster_controller.go 0.00% <ø> (-60.00%) ⬇️
controllers/scc.go 0.00% <ø> (-5.89%) ⬇️
controllers/topolvm_controller.go 0.00% <ø> (-93.91%) ⬇️
controllers/topolvm_csi_driver.go 0.00% <ø> (-68.09%) ⬇️
controllers/topolvm_node.go 0.00% <ø> (-93.13%) ⬇️
controllers/topolvm_snapshotclass.go 0.00% <ø> (-64.45%) ⬇️
controllers/topolvm_storageclass.go 0.00% <ø> (-72.98%) ⬇️
controllers/vgmanager.go 38.29% <ø> (-31.09%) ⬇️

... and 5 files with indirect coverage changes

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2023
api/v1alpha1/webhook_suite_test.go Show resolved Hide resolved
test/e2e/helper.go Show resolved Hide resolved
test/e2e/helper.go Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91 suleymanakbas91 changed the title [OCPVE-309] Remove commented code OCPVE-309: Remove commented code May 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2023

@qJkee: This pull request references OCPVE-309 which is a valid jira issue.

In response to this:

Removed commented code
Bumped ginkgo and controller-runtime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit e6814c5 into openshift:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants