-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-231: Improve the design docs #334
OCPVE-231: Improve the design docs #334
Conversation
@suleymanakbas91: This pull request references OCPVE-231 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
1c465e2
to
1c437a0
Compare
1c437a0
to
11c797f
Compare
/hold |
@suleymanakbas91: This pull request references OCPVE-231 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
11c797f
to
ed487d4
Compare
/lgtm |
ed487d4
to
2cd2270
Compare
741ca35
to
cb4a933
Compare
cb4a933
to
3f462fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! left a few small comments
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aireilly, qJkee, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Suleyman Akbas <[email protected]>
3f462fc
to
afa6b28
Compare
/unhold |
/lgtm |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 46.95% 47.17% +0.22%
==========================================
Files 22 22
Lines 2232 2232
==========================================
+ Hits 1048 1053 +5
+ Misses 1106 1102 -4
+ Partials 78 77 -1
|
@suleymanakbas91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR improves the content of the documentation under the design folder.