Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-231: Improve the design docs #334

Merged

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented May 2, 2023

This PR improves the content of the documentation under the design folder.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2023

@suleymanakbas91: This pull request references OCPVE-231 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 2, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@suleymanakbas91 suleymanakbas91 force-pushed the refactor-desing-docs branch from 1c465e2 to 1c437a0 Compare May 2, 2023 14:28
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 2, 2023
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-desing-docs branch from 1c437a0 to 11c797f Compare May 3, 2023 15:03
@suleymanakbas91 suleymanakbas91 marked this pull request as ready for review May 3, 2023 15:03
@suleymanakbas91
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 3, 2023

@suleymanakbas91: This pull request references OCPVE-231 which is a valid jira issue.

In response to this:

This PR improves the content of the documentation under the design folder.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jerpeter1 and qJkee May 3, 2023 15:07
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-desing-docs branch from 11c797f to ed487d4 Compare May 3, 2023 16:54
@jeff-roche
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-desing-docs branch from ed487d4 to 2cd2270 Compare May 3, 2023 16:57
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-desing-docs branch 3 times, most recently from 741ca35 to cb4a933 Compare May 5, 2023 12:56
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-desing-docs branch from cb4a933 to 3f462fc Compare May 5, 2023 13:26
@suleymanakbas91 suleymanakbas91 linked an issue May 8, 2023 that may be closed by this pull request
Copy link

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left a few small comments

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aireilly, qJkee, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Suleyman Akbas <[email protected]>
@suleymanakbas91 suleymanakbas91 force-pushed the refactor-desing-docs branch from 3f462fc to afa6b28 Compare May 8, 2023 11:15
@suleymanakbas91
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2023
@qJkee
Copy link
Contributor

qJkee commented May 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #334 (afa6b28) into main (166b452) will increase coverage by 0.22%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   46.95%   47.17%   +0.22%     
==========================================
  Files          22       22              
  Lines        2232     2232              
==========================================
+ Hits         1048     1053       +5     
+ Misses       1106     1102       -4     
+ Partials       78       77       -1     
Impacted Files Coverage Δ
controllers/lvmcluster_controller.go 60.00% <ø> (ø)

... and 1 file with indirect coverage changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c54c93e into openshift:main May 8, 2023
@suleymanakbas91 suleymanakbas91 deleted the refactor-desing-docs branch September 19, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants