Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: remove topolvm node SCC #33

Closed
wants to merge 1 commit into from
Closed

Conversation

jmolmo
Copy link
Contributor

@jmolmo jmolmo commented Dec 20, 2021

The SCC is not used in this moment.
If you try to install, kustomize produce an error because the file
is not present.

$ IMG=quay.io/sp1098/lvm-operator:latest  make deploy
...
failure on '/home/sapillai/go/src/github.com/red-hat-storage/lvm-operator/config/rbac/topolvm_node_scc.yaml' : lstat /home/sapillai/go/src/github.com/red-hat-storage/lvm-operator/config/rbac/topolvm_node_scc.yaml: no such file or directory, get: invalid source string: topolvm_node_scc.yaml\"\n\n

I will introduce a topolvm node SCC after testing it (wip).

Signed-off-by: Juan Miguel Olmo Martínez [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmolmo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The SCC is not used in this moment.
If you try to install, kustomize produce an error because the file
 is not present.
I will introduce a topolvm node SCC after testing it (wip)

Signed-off-by: Juan Miguel Olmo Martínez <[email protected]>
@jmolmo
Copy link
Contributor Author

jmolmo commented Dec 20, 2021

resolved in:

#32

@jmolmo jmolmo closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant