Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-311: Improve Make targets to work on MacOS as well #329

Merged
merged 1 commit into from
Apr 25, 2023
Merged

OCPVE-311: Improve Make targets to work on MacOS as well #329

merged 1 commit into from
Apr 25, 2023

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented Apr 25, 2023 •
edited
Loading

This PR adjusts the sed calls in the Makefile to work on both Linux and MacOS.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023 •
edited by openshift-ci bot
Loading

@suleymanakbas91: This pull request references OCPVE-311 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023 •
edited by openshift-ci bot
Loading

@suleymanakbas91: This pull request references OCPVE-311 which is a valid jira issue.

In response to this:

This PR adjusts the sed calls in the Makefile to work on both Linux and MacOS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91 suleymanakbas91 merged commit 1e9be13 into openshift:main Apr 25, 2023
@suleymanakbas91 suleymanakbas91 deleted the mac-improvements branch April 25, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarwal-mudit agarwal-mudit Awaiting requested review from agarwal-mudit

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@jeff-roche jeff-roche

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suleymanakbas91 @openshift-ci-robot @jeff-roche