-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lvm-operator with lvms wherever required #300
Conversation
@@ -0,0 +1,83 @@ | |||
apiVersion: operators.coreos.com/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 CSV files are added, I think we should add only one.
The new name of the odf lvm operator will be logical volume manager storage (lvms). This commit replaces instances of odf-lvm with lvms in the following: * scc names * labels * storageclasses * volumesnapshotclass Signed-off-by: N Balachandran <[email protected]>
The config files have been modified to use the new name lvms instead of lvm-operator. Signed-off-by: N Balachandran <[email protected]>
Replaces instances of lvm-operator wuth lvms in the operf.go. Signed-off-by: N Balachandran <[email protected]>
Updates the e2e test files to use lvms instead of lvmo. Signed-off-by: N Balachandran <[email protected]>
Updates the Makefile to replace lvm-operator with lvms. Signed-off-by: N Balachandran <[email protected]>
Updates the bundle manifests with the new name lvms. Signed-off-by: N Balachandran <[email protected]>
Updates the docs with the new pod, sc and volumesnapshot names. Signed-off-by: N Balachandran <[email protected]>
This updates the olm-deploy files to use the new name lvms. Signed-off-by: N Balachandran <[email protected]>
@nbalacha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.12 |
@nbalacha: #300 failed to apply on top of branch "release-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This changes the name of the lvm operator to lvms.