Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lvm-operator with lvms wherever required #300

Merged
merged 8 commits into from
Dec 14, 2022

Conversation

nbalacha
Copy link
Contributor

This changes the name of the lvm operator to lvms.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@@ -0,0 +1,83 @@
apiVersion: operators.coreos.com/v1alpha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 CSV files are added, I think we should add only one.

Verified

This commit was signed with the committer’s verified signature.
rubvs Ruben van Staden
The new name of the odf lvm operator will be logical volume manager
storage (lvms). This commit replaces instances of odf-lvm with lvms
in the following:
 * scc names
 * labels
 * storageclasses
 * volumesnapshotclass

Signed-off-by: N Balachandran <[email protected]>
The config files have been modified to use the new name
lvms instead of lvm-operator.

Signed-off-by: N Balachandran <[email protected]>
Replaces instances of lvm-operator wuth lvms in the operf.go.

Signed-off-by: N Balachandran <[email protected]>
Updates the e2e test files to use lvms instead of lvmo.

Signed-off-by: N Balachandran <[email protected]>
Updates the Makefile to replace lvm-operator with lvms.

Signed-off-by: N Balachandran <[email protected]>
Updates the bundle manifests with the new name lvms.

Signed-off-by: N Balachandran <[email protected]>
Updates the docs with the new pod, sc and volumesnapshot names.

Signed-off-by: N Balachandran <[email protected]>
This updates the olm-deploy files to use the new name
lvms.

Signed-off-by: N Balachandran <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

@nbalacha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lvm-operator-bundle-e2e-aws 3b68ceb link false /test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d61cc14 into openshift:main Dec 14, 2022
@nbalacha
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@nbalacha: #300 failed to apply on top of branch "release-4.12":

Applying: fix: renames lvmo to lvms
Applying: fix: updates config files with new name
Using index info to reconstruct a base tree...
M	config/manager/manager.yaml
Falling back to patching base and 3-way merge...
Auto-merging config/manager/manager.yaml
CONFLICT (content): Merge conflict in config/manager/manager.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 fix: updates config files with new name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants