chore: update the weekly build github action #290
Conversation
openshift-ci
bot
added
the
approved
.github/workflows/manual-build.yaml
Outdated
| with: | ||
| go-version: ${{ env.GO_VERSION }} | ||
| go-version-file: go.mod | ||
| ref: ${{ github.event.inputs.branch }} |
There was a problem hiding this comment.
I think this ref should go under the checkout not under setup-go
| @@ -45,21 +45,40 @@ jobs: | |||
| uses: docker/login-action@v1 | |||
| with: | |||
| registry: quay.io | |||
| username: ${{ secrets.QUAY_LVMO_ROBOT_NAME_2 }} | |||
| password: ${{ secrets.QUAY_LVMO_ROBOT_TOKEN_2 }} | |||
| username: ${{ secrets.QUAY_LVMO_ROBOT_NAME }} | |||
There was a problem hiding this comment.
The changes look good to me, I think we should use registry_namespace here instead of the secrets. Because if someone gives values other than lvmo we won't be able to push the images though login will succeed. I would like it to fail earlier in that case at login itself. Also we can move login a bit up in the steps before go cache stuff.
.github/workflows/weekly-build.yaml
Outdated
| run: make docker-push IMG=${{env.IMG}} | ||
| workflow: manual-operator-build-push | ||
| repo: red-hat-storage/lvm-operator | ||
| inputs: '{ "branch": "main"}' |
There was a problem hiding this comment.
| inputs: '{ "branch": "main"}' | |
| inputs: '{ "branch": "main" }' |
.github/workflows/weekly-build.yaml
Outdated
| run: make docker-push IMG=${{env.IMG}} | ||
| workflow: manual-operator-build-push | ||
| repo: red-hat-storage/lvm-operator | ||
| inputs: '{ "branch": "main"}' |
There was a problem hiding this comment.
or
| inputs: '{ "branch": "main"}' | |
| inputs: '{"branch": "main"}' |
Updates the weekly build github action to call a second workflow. This will allow us to trigger a build for red-hat-storage/topolvm as part of the weekly build. Signed-off-by: N Balachandran <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates the weekly build github action to call a second workflow. This will allow us to trigger a build for red-hat-storage/topolvm as part of the weekly build.
Signed-off-by: N Balachandran [email protected]