Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing ns labels for make deploy #284

Merged
merged 1 commit into from
Nov 3, 2022
Merged

fix: add missing ns labels for make deploy #284

merged 1 commit into from
Nov 3, 2022

Conversation

nbalacha
Copy link
Contributor

@nbalacha nbalacha commented Nov 3, 2022

The namespace created by make deploy was missing the PSA labels, preventing the topolvm-node and vg-manager pods from starting on OCP 4.12. This commit adds them and the missing cluster monitoring label.

Signed-off-by: N Balachandran [email protected]

@nbalacha nbalacha requested a review from iamniting November 3, 2022 08:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@nbalacha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lvm-operator-bundle-e2e-aws 3136267 link false /test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

iamniting
iamniting suggested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove these #

@nbalacha
fix: add missing ns labels in make deploy
6fd6dda 
The namespace created by make deploy was missing the PSA
labels, preventing the topolvm-node and vg-manager pods
from starting on OCP 4.12. This commit adds them and the missing
cluster monitoring label.

Signed-off-by: N Balachandran <[email protected]>
@nbalacha
Copy link
Contributor Author

nbalacha commented Nov 3, 2022

I think we should remove these #

Fixed

@nbalacha nbalacha requested a review from iamniting November 3, 2022 09:33
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 086aa4c into openshift:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

Assignees

@iamniting iamniting

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbalacha @iamniting @openshift-merge-robot