Create validation webhook for lvmcluster #255
Conversation
Signed-off-by: Nitin Goyal <[email protected]>
Output of: ./bin/operator-sdk create webhook --group lvm --version v1alpha1 --kind LVMCluster --programmatic-validation Signed-off-by: Nitin Goyal <[email protected]>
iamniting
force-pushed
the
webhook-v1
branch
from
af8e126 to
fe7db9e
Compare
|
@nbalacha @sp98 We have one corner case for the update validation where we should allow the user to delete the wrong path from the LVMCluster but we are not. As it is really difficult to find if the path is really wrong or not from the webhook server. Steps to reproduce:
Workaround:
|
iamniting
force-pushed
the
webhook-v1
branch
2 times, most recently
from
ab698ac to
fa75cd7
Compare
| apiVersion: cert-manager.io/v1 | ||
| kind: Certificate | ||
| metadata: | ||
| name: serving-cert # this name should match the one appeared in kustomizeconfig.yaml |
There was a problem hiding this comment.
I don't see this in kustomizeconfig.yaml
There was a problem hiding this comment.
This is not required as we are not using cert-manager in the openshift
There was a problem hiding this comment.
How are certificates set up in Openshift? What about if the operator is installed on plain K8s?
There was a problem hiding this comment.
They are set up using the https://github.com/openshift/service-ca-operator and OLM.
In the case of k8s user has to make changes to the manifests to get it working in k8s.
iamniting
force-pushed
the
webhook-v1
branch
2 times, most recently
from
82eccb0 to
8853ee1
Compare
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
iamniting
force-pushed
the
webhook-v1
branch
from
8853ee1 to
08188c4
Compare
|
@iamniting: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| if val, ok := devices[nodeSelector][path]; ok { | ||
| var err error | ||
| if val != deviceClass.Name { | ||
| err = fmt.Errorf("Error: device path %s overlaps in two different deviceClasss %s and %s", path, val, deviceClass.Name) |
There was a problem hiding this comment.
Ideally this is no required seeing that we are now restricting it to one deviceClass.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
webhook intercepts the faulty CR and raises an appropriate error to guide the user.
Signed-off-by: Nitin Goyal [email protected]
Ref:
https://olm.operatorframework.io/docs/advanced-tasks/adding-admission-and-conversion-webhooks/
https://github.com/openshift/service-ca-operator