test: added the test for ephemeral volume in e2e #246

riya-singhal31 · 2022-08-24T13:55:26Z

This PR adds the test for ephemeral volume, by creating a pod for ephemeral volume and confirming its lifetime.
Also creates snapshot and clone for the ephemeral volume.

Signed-off-by: riya-singhal31 [email protected]

nbalacha · 2022-08-24T14:46:51Z

e2e/testdata/ephemeral_test/pod-ephemeral-volume-device.yaml

+          resources:
+            requests:
+              storage: 1Gi
+          storageClassName: %s 


Suggested change

storageClassName: %s

storageClassName: %s

volumeMode: Block

nbalacha · 2022-08-24T14:57:21Z

e2e/ephemeral_check.go

+
+func ephemeralTest() {
+	Describe("Ephemeral Volume Tests", func() {
+		var pvc *k8sv1.PersistentVolumeClaim


Suggested change

var pvc *k8sv1.PersistentVolumeClaim

var pvc *k8sv1.PersistentVolumeClaim = &k8sv1.PersistentVolumeClaim{}

nbalacha · 2022-08-24T14:58:09Z

e2e/ephemeral_check.go

+				fmt.Printf("Pod %s is running\n", ephemeralPod.Name)
+
+				By("Creating a Snapshot of the pvc")
+				snapshotYaml := fmt.Sprintf(volumeSnapshotYAMLTemplate, "ephemeralfilepvc-snapshot", testNamespace, snapshotClass, "ephemeral-filepod-generic-ephemeral-volume")


Create separate YAMLs for each resource you create in this test in the ephemeral_tests dir. It makes it easy to keep track of which file is used in which test.
Rename ephemeral_test dir to ephemeral_tests.

nbalacha · 2022-08-24T15:04:41Z

e2e/testdata/ephemeral_test/pod-ephemeral-volume-mount.yaml

+          - ReadWriteOnce
+          resources:
+            requests:
+              storage: 1Gi


PVC Clone operations will fail because the size in the pvcCloneYAMLTemplate does not match the size in the ephemeral volume spec. Please create a different yaml in the ephemeral_tests dir.

nbalacha · 2022-08-24T15:14:33Z

e2e/ephemeral_check.go

+				By("Verifying that the Snapshot is ready")
+				Eventually(func() bool {
+					err := crClient.Get(ctx, types.NamespacedName{Name: snapshot.Name, Namespace: snapshot.Namespace}, snapshot)
+					return err == nil && *snapshot.Status.ReadyToUse


Suggested change

return err == nil && *snapshot.Status.ReadyToUse

return err == nil && snapshot.Status != nil && *snapshot.Status.ReadyToUse

nbalacha · 2022-08-24T15:15:23Z

e2e/ephemeral_check.go

+				By("Verifying that the Snapshot is ready")
+				Eventually(func() bool {
+					err := crClient.Get(ctx, types.NamespacedName{Name: snapshot.Name, Namespace: snapshot.Namespace}, snapshot)
+					return err == nil && *snapshot.Status.ReadyToUse


Suggested change

return err == nil && *snapshot.Status.ReadyToUse

return err == nil && snapshot.Status != nil && *snapshot.Status.ReadyToUse

nbalacha · 2022-08-25T06:13:59Z

e2e/lvm_suite_test.go

@@ -26,4 +26,5 @@ var _ = AfterSuite(func() {
 var _ = Describe("LVMO e2e tests", func() {
 	Context("LVMCluster reconciliation", validateResources)
 	Context("PVC tests", pvcTest)
+	Context("Ephemeral tests", ephemeralTest)


Suggested change

Context("Ephemeral tests", ephemeralTest)

Context("Ephemeral volume tests", ephemeralTest)

nbalacha

Please update https://github.com/red-hat-storage/lvm-operator/blob/a99277e6e488db82f43faac58201cedeca0f4ff4/.github/workflows/conf/yamllint.yaml#L7 to ignore the newly added template yamls .

riya-singhal31 · 2022-08-25T06:34:46Z

Please update

https://github.com/red-hat-storage/lvm-operator/blob/a99277e6e488db82f43faac58201cedeca0f4ff4/.github/workflows/conf/yamllint.yaml#L7

to ignore the newly added template yamls .

Thanks for mentioning. Updated.

Yuggupta27 · 2022-08-25T07:16:19Z

e2e/ephemeral_check.go

+//go:embed testdata/ephemeral_tests/pod-ephemeral-volume-device.yaml
+var podEphemeralBlockYAMLTemplate string
+
+//go:embed testdata/ephemeral_tests/pod-ephemeral-volume-mount.yaml
+var podEphemeralFSYAMLTemplate string
+
+//go:embed testdata/ephemeral_tests/ephemeral-volume-snapshot.yaml
+var ephemeralVolumeSnapshotYAMLTemplate string
+
+//go:embed testdata/ephemeral_tests/ephemeral-clone.yaml
+var ephemeralPvcCloneYAMLTemplate string
+
+//go:embed testdata/ephemeral_tests/ephemeral-snapshot-restore.yaml
+var ephemeralPvcSnapshotRestoreYAMLTemplate string
+
+//go:embed testdata/ephemeral_tests/pod-volume-mount-template.yaml
+var podFSYAMLTemplate string
+
+//go:embed testdata/ephemeral_tests/pod-volume-device-template.yaml
+var podBlockYAMLTemplate string


Instead of multiple variable declarations, create a var block?

Thanks, updated.

Yuggupta27 · 2022-08-25T07:20:24Z

e2e/ephemeral_check.go

+					return err == nil && ephemeralPod.Status.Phase == k8sv1.PodRunning
+				}, timeout, interval).Should(BeTrue())
+				fmt.Printf("Pod %s is running\n", ephemeralPod.Name)
+
+				By("Creating a Snapshot of the pvc")


Write some data in the parent pvc and verify it later on cloned/restored volumes?

There's another PR doing this check. #235
Will modify once that gets merged.

Signed-off-by: riya-singhal31 <[email protected]>

openshift-ci · 2022-08-25T09:38:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, riya-singhal31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nbalacha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

riya-singhal31 changed the title ~~test: added the test for ephemeral volume in e2e~~ [WIP]test: added the test for ephemeral volume in e2e Aug 24, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2022

riya-singhal31 force-pushed the ephemeral-test branch 2 times, most recently from d3da6a5 to b6e050d Compare August 24, 2022 14:01

nbalacha suggested changes Aug 24, 2022

View reviewed changes

openshift-ci bot assigned nbalacha Aug 24, 2022

riya-singhal31 force-pushed the ephemeral-test branch 2 times, most recently from 4ebff69 to 1462926 Compare August 25, 2022 05:31

riya-singhal31 changed the title ~~[WIP]test: added the test for ephemeral volume in e2e~~ test: added the test for ephemeral volume in e2e Aug 25, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022

riya-singhal31 force-pushed the ephemeral-test branch from 1462926 to e5b319e Compare August 25, 2022 05:39

riya-singhal31 changed the title ~~test: added the test for ephemeral volume in e2e~~ [WIP]test: added the test for ephemeral volume in e2e Aug 25, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022

nbalacha reviewed Aug 25, 2022

View reviewed changes

riya-singhal31 force-pushed the ephemeral-test branch from e5b319e to 595aedf Compare August 25, 2022 06:21

riya-singhal31 changed the title ~~[WIP]test: added the test for ephemeral volume in e2e~~ test: added the test for ephemeral volume in e2e Aug 25, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2022

nbalacha suggested changes Aug 25, 2022

View reviewed changes

riya-singhal31 force-pushed the ephemeral-test branch 2 times, most recently from 3e32301 to f1590cd Compare August 25, 2022 06:31

Yuggupta27 suggested changes Aug 25, 2022

View reviewed changes

openshift-ci bot assigned Yuggupta27 Aug 25, 2022

test: added the test for ephemeral volume in e2e

4808fca

Signed-off-by: riya-singhal31 <[email protected]>

riya-singhal31 force-pushed the ephemeral-test branch from f1590cd to 4808fca Compare August 25, 2022 07:39

riya-singhal31 requested review from nbalacha, Yuggupta27 and sp98 August 25, 2022 07:41

nbalacha approved these changes Aug 25, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022

openshift-merge-robot merged commit a6d1875 into openshift:main Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: added the test for ephemeral volume in e2e #246

test: added the test for ephemeral volume in e2e #246

riya-singhal31 commented Aug 24, 2022 •

edited

Loading

nbalacha Aug 24, 2022

riya-singhal31 Aug 25, 2022

nbalacha Aug 24, 2022

nbalacha Aug 24, 2022

nbalacha Aug 24, 2022

nbalacha Aug 24, 2022

nbalacha Aug 24, 2022

nbalacha Aug 25, 2022

nbalacha left a comment

riya-singhal31 commented Aug 25, 2022

Yuggupta27 Aug 25, 2022

riya-singhal31 Aug 25, 2022

Yuggupta27 Aug 25, 2022

riya-singhal31 Aug 25, 2022

openshift-ci bot commented Aug 25, 2022

	var pvc *k8sv1.PersistentVolumeClaim
	var pvc *k8sv1.PersistentVolumeClaim = &k8sv1.PersistentVolumeClaim{}

	return err == nil && *snapshot.Status.ReadyToUse
	return err == nil && snapshot.Status != nil && *snapshot.Status.ReadyToUse

	Context("Ephemeral tests", ephemeralTest)
	Context("Ephemeral volume tests", ephemeralTest)

test: added the test for ephemeral volume in e2e #246

test: added the test for ephemeral volume in e2e #246

Conversation

riya-singhal31 commented Aug 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nbalacha left a comment

Choose a reason for hiding this comment

riya-singhal31 commented Aug 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci bot commented Aug 25, 2022

riya-singhal31 commented Aug 24, 2022 •

edited

Loading