Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: github action to run 'make test' on every pr #24

Merged
merged 1 commit into from
Dec 16, 2021
Merged

ci: github action to run 'make test' on every pr #24

merged 1 commit into from
Dec 16, 2021

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 15, 2021

Signed-off-by: Leela Venkaiah G [email protected]

@leelavg
Copy link
Contributor Author

leelavg commented Dec 16, 2021

Please replace envtest there as well.

  • I did see that actually and at the same time, current action has only envtest so didn't change that for easy ref
  • Still want me to change?

@nbalacha
Copy link
Contributor

Please replace envtest there as well.

  • I did see that actually and at the same time, current action has only envtest so didn't change that for easy ref
  • Still want me to change?

Yes.

@leelavg leelavg changed the title ci: github action to run envtest on every pr ci: github action to run 'make test' on every pr Dec 16, 2021
nbalacha
nbalacha approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nbalacha nbalacha merged commit c9c2b6d into openshift:main Dec 16, 2021
@leelavg leelavg deleted the test-action branch December 21, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmolmo jmolmo jmolmo approved these changes

@nbalacha nbalacha nbalacha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leelavg @nbalacha @jmolmo