fix: renamed service account #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test lvm-operator-bundle-e2e-aws |
|
csv changes are missing. |
changed service account name from controller-manager to lvm-controller-manager to avoid clashes between various operators installed in same namespace. Signed-off-by: riya-singhal31 <[email protected]>
riya-singhal31
force-pushed
the
rename-sa
branch
from
5a7bce6 to
b354409
Compare
Updated |
nbalacha
approved these changes
Aug 17, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbalacha, riya-singhal31 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed service account name from default controller-manager to
lvm-controller-manager to distinguish it with various other operators
installed in same namespace.
Output from terminal:
[riyasinghal@fedora lvm-operator]$ oc get sa -n openshift-storage
NAME SECRETS AGE
builder 2 3m36s
default 2 3m36s
deployer 2 3m36s
lvm-catalogsource 2 3m36s
lvm-controller-manager 2 2m34s
topolvm-controller 2 2m37s
topolvm-node 2 2m35s
vg-manager 2 2m39s
Signed-off-by: riya-singhal31 [email protected]