Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2083441: Volume snapshot class bp #189

Merged

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented May 11, 2022

Backport PR. Commits are cherry picked from #183

sp98 added 5 commits May 11, 2022 17:02
- creates volume snapshot class when lvm cluster is created
- deletes volume snaphot class when lvm cluster is deleted
- adds a new CRD for volume snapshot class
- Updates tests to add volume snapshot class to scheme

Signed-off-by: Santosh Pillai <[email protected]>
(cherry picked from commit 7322111)
Signed-off-by: Santosh Pillai <[email protected]>
(cherry picked from commit 56c7b41)
Signed-off-by: Santosh Pillai <[email protected]>
(cherry picked from commit 5239637)
Signed-off-by: Santosh Pillai <[email protected]>
(cherry picked from commit 79a3d9b)
Signed-off-by: Santosh Pillai <[email protected]>
(cherry picked from commit b15a466)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@sp98: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Volume snapshot class bp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp98 sp98 changed the title Volume snapshot class bp Bug 2083441: Volume snapshot class bp May 11, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@sp98: This pull request references Bugzilla bug 2083441, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.11.0) matches configured target release for branch (ODF 4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2083441: Volume snapshot class bp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 72dfd6d into openshift:release-4.11 May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@sp98: All pull requests linked via external trackers have merged:

Bugzilla bug 2083441 has been moved to the MODIFIED state.

In response to this:

Bug 2083441: Volume snapshot class bp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants