Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: convert vg manager clusterrole into role as per requirements #178

Merged
merged 2 commits into from
Apr 29, 2022
Merged

build: convert vg manager clusterrole into role as per requirements #178

merged 2 commits into from
Apr 29, 2022

Conversation

iamniting
Copy link
Member

Signed-off-by: Nitin Goyal [email protected]

@iamniting iamniting requested review from nbalacha and leelavg April 28, 2022 07:19
@iamniting iamniting force-pushed the change-vg-manager-rbac branch from 788672a to cadcf31 Compare April 28, 2022 07:21
leelavg
leelavg approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
nbalacha
nbalacha suggested changes Apr 29, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@iamniting iamniting force-pushed the change-vg-manager-rbac branch from cadcf31 to 17daa16 Compare April 29, 2022 05:23
@iamniting iamniting requested a review from nbalacha April 29, 2022 05:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@iamniting: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lvm-operator-bundle-e2e-aws 17daa16 link false /test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iamniting
Copy link
Member Author

/test lvm-operator-bundle-e2e-aws

@iamniting iamniting force-pushed the change-vg-manager-rbac branch from 17daa16 to 2c95f13 Compare April 29, 2022 09:49
@iamniting iamniting requested a review from nbalacha April 29, 2022 09:52
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5f44cec into openshift:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbalacha nbalacha nbalacha approved these changes

@leelavg leelavg leelavg approved these changes

Assignees

@nbalacha nbalacha

@leelavg leelavg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamniting @nbalacha @leelavg @openshift-merge-robot