Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refer to release-4.11 topolvm ds branch #173

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Apr 27, 2022

Upstream PR for snapshot topolvm/topolvm#463
couldn't be merged before 4.11 feature freeze. So snapshot changes were pushed
to downstream topolvm in the release-4.11 branch.

This PR makes lvm operator to refer to the downstream topolvm
release-4.11 branch untill the snapshot PR is merged upstream.

  • update go.mod to point to release-4.11
  • update topolvm image to quay.io/ocs-dev/topolvm:latest

Tested snapshot, restore and clone feature on SNO-3

Every 2.0s: oc get pods                                                                                                                               localhost.localdomain: Fri Apr 29 19:31:44 2022

NAME                                               READY   STATUS    RESTARTS   AGE
lvm-operator-controller-manager-794c79649f-55jlx   3/3     Running   0          16m
my-pod                                             1/1     Running   0          11m
my-pod-clone                                       1/1     Running   0          10m
my-pod-restore                                     1/1     Running   0          10m
topolvm-controller-966fbd-dr7rz                    5/5     Running   0          15m
topolvm-node-pg2xw                                 4/4     Running   0          15m
vg-manager-n59r8                                   1/1     Running   0          15m

sh-4.4# lvs
  LV                                   VG  Attr       LSize Pool        Origin                               Data%  Meta%  Move Log Cpy%Sync Convert
  09b67867-3517-4692-8bcf-8f2139ff1020 vg2 Vri---tz-k 2.00g thin-pool-2 f1798fba-945d-4b69-adf2-49b0432d4cb5
  26113626-de97-4f16-9e04-e2fc5be7cb69 vg2 Vwi-aotz-k 2.00g thin-pool-2 f1798fba-945d-4b69-adf2-49b0432d4cb5 0.73
  cae5a5ad-6449-42d3-bf35-24f5ba7d3503 vg2 Vwi-aotz-k 2.00g thin-pool-2 09b67867-3517-4692-8bcf-8f2139ff1020 0.73
  f1798fba-945d-4b69-adf2-49b0432d4cb5 vg2 Vwi-aotz-- 2.00g thin-pool-2                                      0.73
  thin-pool-2                          vg2 twi-aotz-- 2.18t                                                  0.01   6.13
sh-4.4#

$ oc get pvc                       
NAME                  STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
topolvm-pvc-clone     Bound    pvc-e61e773c-ef85-49af-826b-159ade8576bd   2Gi        RWO            odf-lvm-vg2    11m
topolvm-pvc-restore   Bound    pvc-120210e3-8eee-4e82-904a-6c266fc34439   2Gi        RWO            odf-lvm-vg2    10m
topolvm-pvc-thin      Bound    pvc-a3fdc488-6b2c-4e15-aee2-f618100dcdcf   2Gi        RWO            odf-lvm-vg2    12m

Signed-off-by: Santosh Pillai [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2022
@sp98 sp98 changed the title fix: refer to test-branch in ds topolvm refer to release-4.11 topolvm ds branch Apr 29, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2022
Upstream PR for snapshot topolvm/topolvm#463
couldn't be merged before 4.11 feature freeze. So snapshot changes were pushed
to downstream topolvm in the `release-4.11` branch.

This PR makes lvm operator to refer to the downstream topolvm
`release-4.11` branch untill the snapshot PR is merged upstream.

- update go.mod to point to release-4.11
- update topolvm image to quay.io/ocs-dev/topolvm:latest

Signed-off-by: Santosh Pillai <[email protected]>
@sp98 sp98 marked this pull request as ready for review April 29, 2022 13:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2022
@sp98 sp98 requested review from nbalacha and leelavg April 29, 2022 13:59
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit d059fe4 into openshift:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants