-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing files for make bundle
#167
Conversation
make bundle
make bundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these do not need to be updated. They are temporary files generated from templates.
However, bundle/manifests/lvm-operator.clusterserviceversion.yaml needs to be updated as the image is incorrect.
config/default/kustomization.yaml
Outdated
@@ -1,5 +1,5 @@ | |||
# Adds namespace to all resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was updated by the make bundle target as we use different ns for upstream and downstream and ca be ignored.
@@ -285,7 +285,7 @@ spec: | |||
valueFrom: | |||
fieldRef: | |||
fieldPath: metadata.name | |||
image: quay.io/nibalach/lvm-operator:e2e | |||
image: quay.io/ocs-dev/lvm-operator:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be committed.
@@ -0,0 +1,21 @@ | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a file generated by make update-mgr-env and does not need to be committed.
config/manager/kustomization.yaml
Outdated
@@ -3,3 +3,10 @@ resources: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required to be committed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbalacha how about adding unwanted files to gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is required. If it makes things less confusing, we can merge the temporary files as they will be overwritten anyway by the make targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes as you mentioned it's less confusing and helps both contributors and maintainers to keep track of it.
After running `make bundle` locally few files got updated and new files also got added. Signed-off-by: Madhu Rajanna <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After running
make bundle
locally few files got updated and new files also got added.Signed-off-by: Madhu Rajanna [email protected]
/cc @nbalacha