Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a csi-snapshotter as a sidecar into topolvm_controller #159

Merged
merged 4 commits into from
Apr 28, 2022
Merged

feat: add a csi-snapshotter as a sidecar into topolvm_controller #159

merged 4 commits into from
Apr 28, 2022

Conversation

iamniting
Copy link
Member

@iamniting iamniting commented Apr 20, 2022 •
edited
Loading

Madhu-1
Madhu-1 suggested changes Apr 20, 2022
View reviewed changes
@iamniting iamniting requested a review from Madhu-1 April 20, 2022 11:10
Madhu-1
Madhu-1 suggested changes Apr 20, 2022
View reviewed changes
controllers/topolvm_controller.go Outdated
{Name: "socket-dir", MountPath: filepath.Dir(DefaultCSISocket)},
}

csiSnapshoter := &corev1.Container{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we dont have resource limits for this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbalacha @Yuggupta27 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added very minimal ones, I will change them if required.

nbalacha
nbalacha suggested changes Apr 20, 2022
View reviewed changes
@iamniting iamniting requested review from nbalacha and Madhu-1 April 20, 2022 11:25
Madhu-1
Madhu-1 reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs to adjust the commit title and PR title.

@iamniting iamniting changed the title feat: Add a snapshot controller as a sidecar into topolvm_controller feat: add a csi-snapshotter as a sidecar into topolvm_controller Apr 20, 2022
@iamniting
Copy link
Member Author

LGTM, needs to adjust the commit title and PR title.

done

@iamniting iamniting requested a review from Madhu-1 April 20, 2022 12:07
Madhu-1
Madhu-1 reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to mention this one.
RBAC needs to be adjusted here https://github.com/red-hat-storage/lvm-operator/blob/main/config/rbac/topolvm_controller_role.yaml#L100-L114 same as https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/csi-snapshotter/rbac-csi-snapshotter.yaml#L23-L41

nbalacha
nbalacha suggested changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update config/default/manager_custom_env.yaml.in and the update-mgr-env Makefile target with the new ENV variable.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2022
@iamniting iamniting requested review from Madhu-1 and nbalacha April 21, 2022 06:35
@iamniting
Copy link
Member Author

Please update config/default/manager_custom_env.yaml.in and the update-mgr-env Makefile target with the new ENV variable.

done

@iamniting
Copy link
Member Author

forgot to mention this one. RBAC needs to be adjusted here https://github.com/red-hat-storage/lvm-operator/blob/main/config/rbac/topolvm_controller_role.yaml#L100-L114 same as https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/csi-snapshotter/rbac-csi-snapshotter.yaml#L23-L41

added

@iamniting
Copy link
Member Author

/test lvm-operator-bundle-e2e-aws

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
Madhu-1
Madhu-1 suggested changes Apr 22, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@iamniting iamniting requested a review from Madhu-1 April 22, 2022 08:26
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@iamniting
Copy link
Member Author

iamniting commented Apr 22, 2022 •
edited
Loading

/hold for testing

@Yuggupta27 pls let me know when your image is ready and we will test it out.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2022
@sp98
Copy link
Contributor

sp98 commented Apr 28, 2022

@iamniting Need to run make bundle as well.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
@iamniting
Copy link
Member Author

@iamniting Need to run make bundle as well.

done

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg, Madhu-1, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 09ba742 into openshift:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp98 sp98 sp98 approved these changes

@nbalacha nbalacha nbalacha approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@leelavg leelavg leelavg approved these changes

@Yuggupta27 Yuggupta27 Awaiting requested review from Yuggupta27

Assignees

@sp98 sp98

@nbalacha nbalacha

@Madhu-1 Madhu-1

@leelavg leelavg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iamniting @sp98 @nbalacha @Madhu-1 @leelavg @openshift-merge-robot