Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add snapshot related commands in must-gather #145

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

agarwal-mudit
Copy link
Contributor

Add commands in must-gather to capture snapshot related
kubernetes objects.

Signed-off-by: Mudit Agarwal [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@agarwal-mudit
Copy link
Contributor Author

/hold
I still need Yug's changes to test this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2022
@agarwal-mudit
Copy link
Contributor Author

Tested on a cluster without snapshots, it is not giving any error.
snapshots are not present so it is just saying No resources found

Add commands in must-gather to capture snapshot related
kubernetes objects.

Signed-off-by: Mudit Agarwal <[email protected]>
@agarwal-mudit
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2022
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine and I will approve it once it has been tested against the snapshot PR.

@agarwal-mudit
Copy link
Contributor Author

@agarwal-mudit
Copy link
Contributor Author

@nbalacha I have uploaded the must-gather for the changed code, please take a look.

@agarwal-mudit agarwal-mudit requested a review from nbalacha April 13, 2022 05:48
@nbalacha
Copy link
Contributor

@nbalacha I have uploaded the must-gather for the changed code, please take a look.

Looks good.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [agarwal-mudit,nbalacha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5be05ff into openshift:main Apr 13, 2022
@agarwal-mudit agarwal-mudit deleted the snap branch April 13, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants