fix: renamed storageclass to remove topolvm #114
Conversation
Replaced "topolvm-" with "odf-lvm" in the storageclass name. Signed-off-by: N Balachandran <[email protected]>
openshift-ci
bot
added
the
approved
| @@ -93,7 +93,7 @@ func getTopolvmStorageClasses(lvmCluster *lvmv1alpha1.LVMCluster) []*storagev1.S | |||
| for _, deviceClass := range lvmCluster.Spec.DeviceClasses { | |||
| storageClass := &storagev1.StorageClass{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: fmt.Sprintf("topolvm-%s", deviceClass.Name), | |||
| Name: fmt.Sprintf("odf-lvm-%s", deviceClass.Name), | |||
There was a problem hiding this comment.
@nbalacha not sure it a problem for upgrades update of storageclass name is not supported we need to delete and recreate it?
There was a problem hiding this comment.
Upgrades are not in the picture as yet as this is the first downstream release.
Not required. This is the name of the resource manager, not the storageclass. |
| @@ -93,7 +93,7 @@ func getTopolvmStorageClasses(lvmCluster *lvmv1alpha1.LVMCluster) []*storagev1.S | |||
| for _, deviceClass := range lvmCluster.Spec.DeviceClasses { | |||
| storageClass := &storagev1.StorageClass{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: fmt.Sprintf("topolvm-%s", deviceClass.Name), | |||
| Name: fmt.Sprintf("odf-lvm-%s", deviceClass.Name), | |||
There was a problem hiding this comment.
- with this change, we are make the project more downstream-ish, as we already have code to determine k8s environment (openshift or other), how about we use that info to decide on
odf-lvm-vstopolvm-?
There was a problem hiding this comment.
I think a more generic sc name is probably fine for both upstream and downstream.
There was a problem hiding this comment.
ack, so we'll proceed with this name for now and later change it to generic then.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.10 |
|
@nbalacha: new pull request created: #116 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Replaced "topolvm-" with "odf-lvm" in the storageclass name.
Signed-off-by: N Balachandran [email protected]