Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates prebuilt img location in doc #111

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: updates prebuilt img location in doc #111

merged 1 commit into from
Feb 15, 2022

Conversation

nbalacha
Copy link
Contributor

Updated the install instructions to point to the lvm-operator
image in quay.io/ocs-dev.

Signed-off-by: N Balachandran [email protected]

Updated the install instructions to point to the lvm-operator
image in quay.io/ocs-dev.

Signed-off-by: N Balachandran <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@mulbc
Copy link
Member

mulbc commented Feb 15, 2022

Can we make the "Build your own image" a collapsible like explained here:
https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab

Because if we rebuilt the image on a schedule, most people will not want to built it themselves, so it shouldn't use up space on their screens and confuse them

@nbalacha
Copy link
Contributor Author

A better way would be to just link it to the doc which describes how to build the operator. That can be taken up in a separate PR.

Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 06afc8f into openshift:main Feb 15, 2022
@nbalacha nbalacha deleted the ocs-dev branch March 22, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants