Notice the notFound err #1473
Notice the notFound err #1473
Conversation
Signed-off-by: lan.tian <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance5890 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -18,9 +18,6 @@ func CombineCABundleConfigMaps(destinationConfigMap ResourceLocation, lister cor | |||
| certificates := []*x509.Certificate{} | |||
| for _, input := range inputConfigMaps { | |||
| inputConfigMap, err := lister.ConfigMaps(input.Namespace).Get(input.Name) | |||
| if apierrors.IsNotFound(err) { | |||
| continue | |||
| } | |||
There was a problem hiding this comment.
The configmap may be present but with empty "ca-bundle.crt" data key. Which will end up in the same situation as non-existing CM.
@deads2k @mfojtik given you created/approved the PR introducing the function (#191). Was the assumption here either of the CMs can be ignored if not present? The current implementation gives impression of AnyOf can be present rather than AllOf.
1 bug description
when resourcesynccontroller miss key configmap in CombineCABundleConfigMaps, and err is notFound, it will continue and ignore this failure, this will cause the caller func generate wrong configurations
2 related issues:
more information, please read the following issues
# issue 702 openshift/cluster-kube-controller-manager-operator kube-controller-manager rootCA miss key conf
# issue 1472 github.com/openshift/library-go missing key configmap