Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 101067: Bug 1946459: fix nfs storage ipv6 add square brackets #743

Conversation

Elbehery
Copy link

Backport of kubernetes#101067

What type of PR is this?

/kind bug
/kind storage
/label nfs
/label ipv6

What this PR does / why we need it:

Fix mounting nfs volumes in ipv6 environment.

Which issue(s) this PR fixes:

Fixes kubernetes#101066

Special notes for your reviewer:

Enclose only ipv6 within [ ].

Fixed mounting of NFS volumes when IPv6 address is used as a server.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 12, 2021
@openshift-ci-robot
Copy link

@Elbehery: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2021

@Elbehery: The label(s) `/label nfs
, /label ipv6

cannot be applied. These labels are supported:platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed`

In response to this:

Backport of kubernetes#101067

What type of PR is this?

/kind bug
/kind storage
/label nfs
/label ipv6

What this PR does / why we need it:

Fix mounting nfs volumes in ipv6 environment.

Which issue(s) this PR fixes:

Fixes kubernetes#101066

Special notes for your reviewer:

Enclose only ipv6 within [ ].

Fixed mounting of NFS volumes when IPv6 address is used as a server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 12, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2021

@Elbehery: This pull request references Bugzilla bug 1946459, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Upstream 101067: Bug 1946459: fix-nfs-storage-ipv6_add_square_brackets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 12, 2021
@openshift-ci openshift-ci bot requested review from mfojtik and sttts May 12, 2021 16:40
@Elbehery Elbehery changed the title Upstream 101067: Bug 1946459: fix-nfs-storage-ipv6_add_square_brackets Upstream: 101067: Bug 1946459: fix-nfs-storage-ipv6_add_square_brackets May 12, 2021
@Elbehery
Copy link
Author

/retest

@Elbehery Elbehery force-pushed the ocp-fix-nfs-storage-ipv6_add_square_brackets branch from 627ae2b to 311fd35 Compare May 12, 2021 17:12
@openshift-ci-robot
Copy link

@Elbehery: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@Elbehery Elbehery changed the title Upstream: 101067: Bug 1946459: fix-nfs-storage-ipv6_add_square_brackets UPSTREAM: 101067: Bug 1946459: fix nfs storage ipv6 add square brackets May 12, 2021
@Elbehery Elbehery force-pushed the ocp-fix-nfs-storage-ipv6_add_square_brackets branch from 311fd35 to 62b32e2 Compare May 12, 2021 19:11
@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label May 12, 2021
@openshift-ci-robot
Copy link

@Elbehery: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci-robot openshift-ci-robot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 12, 2021
@Elbehery Elbehery force-pushed the ocp-fix-nfs-storage-ipv6_add_square_brackets branch from 62b32e2 to 51a197a Compare May 12, 2021 19:28
@openshift-ci-robot
Copy link

@Elbehery: the contents of this pull request could be automatically validated.

The following commits are valid:

@Elbehery
Copy link
Author

/retest

1 similar comment
@Elbehery
Copy link
Author

/retest

@Elbehery
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@Elbehery: This pull request references Bugzilla bug 1946459, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @chao007

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from chao007 May 17, 2021 12:42
@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retest

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@Elbehery: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi 51a197a link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9d99e1c into openshift:master May 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@Elbehery: All pull requests linked via external trackers have merged:

Bugzilla bug 1946459 has been moved to the MODIFIED state.

In response to this:

UPSTREAM: 101067: Bug 1946459: fix nfs storage ipv6 add square brackets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sig-storage] [Driver: nfs] bare-metal IPv6 environment, pods fail to mount nfs storage resources
6 participants