Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating openshift-enterprise-hyperkube builder & base images to be consistent with ART #559

Conversation

openshift-bot
Copy link

@openshift-bot openshift-bot commented Feb 9, 2021

Updating openshift-enterprise-hyperkube images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. bugzilla/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.

Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment
request: openshift-enterprise-hyperkube.yml.

The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #aos-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. Downstream builds
    are already being built with these changes. Merging this PR only improves the fidelity
    of our CI.

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 9, 2021
@openshift-ci-robot
Copy link

@openshift-bot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 2, 2021
@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link

sttts commented Mar 2, 2021

/lgtm
/approve

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.8-openshift-enterprise-hyperkube branch from 74b2363 to 59a023a Compare March 23, 2021 13:46
@openshift-ci-robot
Copy link

@openshift-bot: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@soltysh soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 23, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link

soltysh commented Nov 18, 2021

/retest-required

@soltysh
Copy link

soltysh commented Nov 18, 2021

/override ci/prow/configmap-scale
which is optional

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2021

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/configmap-scale

In response to this:

/override ci/prow/configmap-scale
which is optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link

soltysh commented Nov 18, 2021

/override ci/prow/configmap-scale
which is optional

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2021

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/configmap-scale

In response to this:

/override ci/prow/configmap-scale
which is optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link

soltysh commented Nov 18, 2021

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 18, 2021
@soltysh
Copy link

soltysh commented Nov 18, 2021

/retest-required

1 similar comment
@soltysh
Copy link

soltysh commented Nov 19, 2021

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2021
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Nov 19, 2021
@openshift-ci-robot
Copy link

@openshift-bot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.8-openshift-enterprise-hyperkube branch from 82fc666 to aa3199d Compare November 19, 2021 17:10
@soltysh
Copy link

soltysh commented Nov 22, 2021

/retest-required

@soltysh
Copy link

soltysh commented Nov 22, 2021

/override e2e-agnostic-cmd
it's being actively worked on
/test e2e-metal-ipi

@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2021

@soltysh: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-agnostic-cmd

Only the following contexts were expected:

  • ci/prow/e2e-agnostic-cmd
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-csi
  • ci/prow/e2e-aws-downgrade
  • ci/prow/e2e-aws-fips
  • ci/prow/e2e-aws-jenkins
  • ci/prow/e2e-aws-multitenant
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-aws-upgrade
  • ci/prow/e2e-azure
  • ci/prow/e2e-azure-upgrade
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-metal-ipi-ovn-dualstack
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-vsphere
  • ci/prow/images
  • ci/prow/integration
  • ci/prow/k8s-e2e-conformance-aws
  • ci/prow/k8s-e2e-gcp
  • ci/prow/k8s-e2e-gcp-serial
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-commits
  • pull-ci-openshift-kubernetes-release-4.10-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-csi
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-downgrade
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-fips
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-jenkins
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-multitenant
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-ovn
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-serial
  • pull-ci-openshift-kubernetes-release-4.10-e2e-aws-upgrade
  • pull-ci-openshift-kubernetes-release-4.10-e2e-azure
  • pull-ci-openshift-kubernetes-release-4.10-e2e-azure-upgrade
  • pull-ci-openshift-kubernetes-release-4.10-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.10-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-release-4.10-e2e-metal-ipi
  • pull-ci-openshift-kubernetes-release-4.10-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-kubernetes-release-4.10-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-kubernetes-release-4.10-e2e-vsphere
  • pull-ci-openshift-kubernetes-release-4.10-images
  • pull-ci-openshift-kubernetes-release-4.10-integration
  • pull-ci-openshift-kubernetes-release-4.10-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-release-4.10-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.10-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-release-4.10-unit
  • pull-ci-openshift-kubernetes-release-4.10-verify
  • pull-ci-openshift-kubernetes-release-4.10-verify-commits
  • tide

In response to this:

/override e2e-agnostic-cmd
it's being actively worked on
/test e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link

soltysh commented Nov 23, 2021

/override ci/prow/e2e-agnostic-cmd
it's being actively worked on
/test e2e-metal-ipi

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2021

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd

In response to this:

/override ci/prow/e2e-agnostic-cmd
it's being actively worked on
/test e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link

soltysh commented Nov 23, 2021

/test e2e-metal-ipi

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Nov 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2021

@openshift-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-selfupgrade 59a023a68f2986a06dfec653d5615e3f6eca82b0 link /test e2e-aws-selfupgrade
ci/prow/e2e-aws-disruptive 825cf6c11d4726dbb73491ba8126605c9a74b488 link /test e2e-aws-disruptive
ci/prow/e2e-aws-single-node 825cf6c11d4726dbb73491ba8126605c9a74b488 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2021

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

Updating openshift-enterprise-hyperkube builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link

soltysh commented Nov 24, 2021

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit e5d52d9 into openshift:release-4.8 Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants