Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2094012: UPSTREAM: 110652: fix: --chunk-size with selector returns missing result #1303

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Bug 2094012: UPSTREAM: 110652: fix: --chunk-size with selector returns missing result #1303

merged 1 commit into from
Jul 1, 2022

Conversation

aojea
Copy link

@aojea aojea commented Jun 29, 2022 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 29, 2022
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh June 29, 2022 11:08
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 29, 2022
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@aojea aojea changed the title Revert "Implement page size progressing for rare selectors." Bug 2094012: UPSTREAM: 110652: fix: --chunk-size with selector returns missing result Jun 30, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@aojea: This pull request references Bugzilla bug 2094012, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2094012: UPSTREAM: 110652: fix: --chunk-size with selector returns missing result

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Author

aojea commented Jun 30, 2022

/assign @tkashem @soltysh @mfojtik @sttts

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@aojea: This pull request references Bugzilla bug 2094012, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 2094012: UPSTREAM: 110652: fix: --chunk-size with selector returns missing result

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 June 30, 2022 08:29
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jun 30, 2022
@openshift-ci-robot
Copy link

@aojea: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@tkashem
Copy link

tkashem commented Jun 30, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@mfojtik
Copy link

mfojtik commented Jun 30, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, mfojtik, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 9ddc8b1 and 8 for PR HEAD de74c89 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 9ddc8b1 and 7 for PR HEAD de74c89 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9ddc8b1 and 6 for PR HEAD de74c89 in total

@tkashem
Copy link

tkashem commented Jun 30, 2022

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

@aojea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade de74c89 link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit d85aeef into openshift:master Jul 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

@aojea: All pull requests linked via external trackers have merged:

Bugzilla bug 2094012 has been moved to the MODIFIED state.

In response to this:

Bug 2094012: UPSTREAM: 110652: fix: --chunk-size with selector returns missing result

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link

mfojtik commented Jul 1, 2022

/cherrypick release-4.11

@openshift-cherrypick-robot
Copy link

@mfojtik: new pull request created: #1304

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@mfojtik mfojtik

@soltysh soltysh

@sttts sttts

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aojea @openshift-ci-robot @tkashem @mfojtik @openshift-cherrypick-robot @soltysh @sttts @Abirdcfly