Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44596: Mount OVS directory instead of socket file #543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkowalski
Copy link

When mounting the OVS DB socket directly as a file (/run/openvswitch/db.sock) instead of mounting the whole directory, handler container loses access to the OVS DB in case of OVS daemon restart on the host. This can only be fixed by restarting the container so that it mounts again the correct file.

To remediate this, we are mounting the whole /run/openvswitch directory so that DB connection can be gracefully restored by the handler itself.

Closes: OCPBUGS-44596

When mounting the OVS DB socket directly as a file
(`/run/openvswitch/db.sock`) instead of mounting the whole directory,
handler container loses access to the OVS DB in case of OVS daemon
restart on the host. This can only be fixed by restarting the container
so that it mounts again the correct file.

To remediate this, we are mounting the whole `/run/openvswitch`
directory so that DB connection can be gracefully restored by the
handler itself.

Closes: OCPBUGS-44596
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2024
@openshift-ci-robot
Copy link

@mkowalski: This pull request references Jira Issue OCPBUGS-44596, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When mounting the OVS DB socket directly as a file (/run/openvswitch/db.sock) instead of mounting the whole directory, handler container loses access to the OVS DB in case of OVS daemon restart on the host. This can only be fixed by restarting the container so that it mounts again the correct file.

To remediate this, we are mounting the whole /run/openvswitch directory so that DB connection can be gracefully restored by the handler itself.

Closes: OCPBUGS-44596

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cybertron and qinqon November 29, 2024 14:54
Copy link

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@mkowalski
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 29, 2024
@openshift-ci-robot
Copy link

@mkowalski: This pull request references Jira Issue OCPBUGS-44596, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rbbratta

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 29, 2024
@openshift-ci openshift-ci bot requested a review from rbbratta November 29, 2024 14:54
Copy link

openshift-ci bot commented Nov 29, 2024

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-handler-azure e7e085c link false /test e2e-handler-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mkowalski
Copy link
Author

/override ci/prow/security

Copy link

openshift-ci bot commented Dec 2, 2024

@mkowalski: Overrode contexts on behalf of mkowalski: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mkowalski
Copy link
Author

/test ci/prow/e2e-handler-azure

Copy link

openshift-ci bot commented Dec 6, 2024

@mkowalski: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test check-generate-bundle
/test e2e-handler-ovn-ipv4
/test e2e-operator-ovn-ipv4
/test images
/test security
/test unit

The following commands are available to trigger optional jobs:

/test e2e-handler-azure

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-handler-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants