-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-44596: Mount OVS directory instead of socket file #543
base: master
Are you sure you want to change the base?
Conversation
When mounting the OVS DB socket directly as a file (`/run/openvswitch/db.sock`) instead of mounting the whole directory, handler container loses access to the OVS DB in case of OVS daemon restart on the host. This can only be fixed by restarting the container so that it mounts again the correct file. To remediate this, we are mounting the whole `/run/openvswitch` directory so that DB connection can be gracefully restored by the handler itself. Closes: OCPBUGS-44596
@mkowalski: This pull request references Jira Issue OCPBUGS-44596, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@mkowalski: This pull request references Jira Issue OCPBUGS-44596, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@mkowalski: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override ci/prow/security |
@mkowalski: Overrode contexts on behalf of mkowalski: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test ci/prow/e2e-handler-azure |
@mkowalski: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When mounting the OVS DB socket directly as a file (
/run/openvswitch/db.sock
) instead of mounting the whole directory, handler container loses access to the OVS DB in case of OVS daemon restart on the host. This can only be fixed by restarting the container so that it mounts again the correct file.To remediate this, we are mounting the whole
/run/openvswitch
directory so that DB connection can be gracefully restored by the handler itself.Closes: OCPBUGS-44596