[4.16] Use cert service #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change add annotations to use openshift cert service and will detect openshift clusters and do the following: - Skip nmstate cert-manager installation - Remove obsolete nmstate-cert-manager deployment Signed-off-by: Enrique Llorente <[email protected]>
The NMState CR has no namespace at all, to remove the obsolete cert-manager at openshift operator should use the HANDLER_NAMESPACE env var. Signed-off-by: Enrique Llorente <[email protected]>
|
/hold 4.17 first |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
The non openshift secret is not compatible with openshift generated version, this change a different one so they don't collide and also remove the old one. Signed-off-by: Enrique Llorente <[email protected]>
|
@mkowalski: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks