OCPCLOUD-2060 Merge https://github.com/kubernetes/autoscaler:master (d3ec0c4) into master #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
Check min size of node group and resource limits for set of nodes
* Added GetNodeGpuConfig to cloud provider which returns a GpuConfig struct containing the gpu label, type and resource name if the node has a GPU. * Added initial implementaion of the GetNodeGpuConfig to all cloud providers.
* Changed the `utilization.Calculate()` function to use GpuConfig instead of GPU label. * Started using GpuConfig in utilization threshold calculations.
Add GpuConfig to cloud provider. Use GpuConfig in utilization calculations.
regenerate the ec2 instance types using latest metadata to fetch m7g/r7g instances
…eCreatedNodesWithErrors
…le down candidate
Fix RemovableAt()
This change removes an `if` statement that was left behind after a refactor. The test in question has the same logic embedded into a previous conditional and the removed statement has no effect on the tests.
remove dead code in clusterapi provider tests
… that is not valid Signed-off-by: cpanato <[email protected]>
Signed-off-by: Guangwen Feng <[email protected]>
…er-chart Bump CA chart to 1.24
Update VPA dependency github.com/emicklei/go-restful/v3
…nodes_total metrics * Added the new resource_name field to scaled_up/down_gpu_nodes_total, representing the resource name for the gpu. * Changed metrics registrations to use GpuConfig
update FAQ.md to add version in the pause container image due the latest that is not valid
Fix a minor typo
Add "resource_name" to scaled_up_gpu_nodes_total and scaled_down_gpu_nodes_total metrics
Added support for the AWS Inferentia 2 instance types based on the NeuronCore v2 chip architecture
…ero-with-labels-taints Use annotations to set labels and taints for clusterapi nodegroups
Merge taint utils into one package, make taint modifying methods public
Track PDBRemainingDisruptions in AutoscalingContext
|
/hold @elmiko Have HyperShift been notified that their tests are failing on this? Is a discussion open there to make sure we don't break them? |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed ack, let them know |
|
/test e2e-hypershift |
I'll update hypershift rbac. |
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Jun 8, 2023
This is needed to let the autoscaler to operate openshift/kubernetes-autoscaler#256 (comment) kubernetes/autoscaler#4676
Merged
4 tasks
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Jun 14, 2023
This is needed to let the autoscaler to operate openshift/kubernetes-autoscaler#256 (comment) kubernetes/autoscaler#4676
orenc1
pushed a commit
to orenc1/hypershift
that referenced
this pull request
Jun 14, 2023
This is needed to let the autoscaler to operate openshift/kubernetes-autoscaler#256 (comment) kubernetes/autoscaler#4676
|
/test e2e-hypershift |
|
it seems like some of our carry commits got dropped, and i'm not sure why. looking into re-adding them thanks to @aleskandro for catching it =) |
|
i think i've fixed the missing commit, see 834cebd i'll wait for tests to start passing before removing the hold |
elmiko
force-pushed
the
rebase-bot-master
branch
from
834cebd to
175bd5e
Compare
|
/test e2e-hypershift |
|
gonna keep the hold here while we work out a question with the scale from zero annotations |
the upstream annotations for the scale from zero capacity resources is slighty different than the openshift implementation. the largest difference is the addition of a gpu type annotation. openshift does not yet utilize this annotation and thus this patch should be carried until the machineset controllers for the various providers on openshift have been modified to use the new annotations. another important change is the modification of the memory annotation. previously in openshift we expected this value to be a count of memory in Mebibytes. the conversion function and tests have been modified to allow continued openshift operation. this change can be dropped when the annotations in openshift have been updated, the progress for this effort can be followed at https://issues.redhat.com/browse/OCPCLOUD-944
elmiko
force-pushed
the
rebase-bot-master
branch
from
175bd5e to
c74af56
Compare
|
/retest |
|
@cloud-team-rebase-bot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/unhold |
openshift-ci
bot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.