This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Test operator TP1-02 via the 0.7.1 CI. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
size/XL
nak3
reviewed
Aug 23, 2019
openshift/e2e-tests-openshift.sh
Outdated
| local KIND=$2 | ||
| function deploy_serverless_operator(){ | ||
| local NAME="serverless-operator" | ||
| local NAMESPACE="knative-serving" |
There was a problem hiding this comment.
We have already SERVING_NAMESPACE and we can use it instead of creating new value.
nak3
reviewed
Aug 23, 2019
openshift/e2e-tests-openshift.sh
Outdated
| kind: KnativeServing | ||
| metadata: | ||
| name: knative-serving | ||
| namespace: knative-serving |
There was a problem hiding this comment.
It would be better to use ${SERVING_NAMESPACE}?
|
LGTM! I just commented a few small stuff. |
|
LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title. Keep this on par with the last version.