terraform: azurerm bump provider to v3.19.1

[r4f4]

This is the first step needed for enabling arm64 support.

/cc @Prashanth684

[r4f4]

/cc @patrickdillon

[patrickdillon]

This LGTM, but how does this enable ARM instances/shared gallery images? The VM resource is already using the image_source_id attribute, which is--I believe--how we would pass a gallery image.

Do we need to read the gallery image as a data source source or something?

[patrickdillon]

This LGTM, but how does this enable ARM instances/shared gallery images? The VM resource is already using the image_source_id attribute, which is--I believe--how we would pass a gallery image.

Do we need to read the gallery image as a data source source or something?

I found the answer in a jira comment, which points to this: hashicorp/terraform-provider-azurerm#17768

[r4f4]

The gallery image work will come in future PRs. @Prashanth684 is working on them.

[Prashanth684]

https://issues.redhat.com/browse/ARMOCP-429 has details about the changes needed for bootimage creation for arm64. The next step will be to add creation of arm64 bootimages using the image gallery.

[Prashanth684]

/retest

[Prashanth684]

/lgtm

[Prashanth684]

@patrickdillon are we good for an approval?

[sadasu]

/test e2e-azurestack

[sadasu]

/test e2e-azure-resourcegroup

[Prashanth684]

/test e2e-azurestack

[Prashanth684]

@sadasu took a brief look at the e2e-azurestack error logs. the nodes are all up and all the operators are up except the csi driver and monitoring . the csi driver pods are failing with CreateContainerConfigError and this message:

secret \"azure-disk-credentials\" not found

i don't think it is related to this change.

[sadasu]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5c8ec74 and 2 for PR HEAD 2e519f0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 679e56e and 1 for PR HEAD 2e519f0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ba0e40c and 0 for PR HEAD 2e519f0 in total

[openshift-ci-robot]

/hold

Revision 2e519f0 was retested 3 times: holding

[Prashanth684]

/retest-required

[Prashanth684]

/test e2e-azure

[Prashanth684]

/retest-required

[Prashanth684]

/hold cancel

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD f2e5195 and 2 for PR HEAD 2e519f0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 82dcbcc and 1 for PR HEAD 2e519f0 in total

[Prashanth684]

/retest-required

[openshift-ci]

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi	2e519f0	link	false	/test e2e-metal-ipi
ci/prow/e2e-libvirt	2e519f0	link	false	/test e2e-libvirt
ci/prow/e2e-openstack	2e519f0	link	false	/test e2e-openstack
ci/prow/e2e-ibmcloud	2e519f0	link	false	/test e2e-ibmcloud
ci/prow/e2e-azurestack	2e519f0	link	false	/test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD f6c8f52 and 0 for PR HEAD 2e519f0 in total