Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2048451: Use proxy dial to validate endpoints #5600

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Bug 2048451: Use proxy dial to validate endpoints #5600

merged 1 commit into from
Feb 4, 2022

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Feb 2, 2022

Using proxy dial instead of the current net dial for validating
service endpoints in AWS since there could be a proxy setup
when an IPI restricted installation occurs that might make the
the endpoints unreachable without using them.

@rna-afk rna-afk changed the title aws: Use proxy dial to validate endpoints Bug 2048451: Use proxy dial to validate endpoints Feb 2, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2022

@rna-afk: This pull request references Bugzilla bug 2048451, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2048451: Use proxy dial to validate endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rna-afk rna-afk force-pushed the use_proxy_dial_aws_endpoint branch 2 times, most recently from ac4d72d to 927f2fe Compare February 3, 2022 16:01
@staebler
Copy link
Contributor

staebler commented Feb 3, 2022

You need to update the vendor, too, to get the golang.org/x/net/proxy module.

@rna-afk rna-afk force-pushed the use_proxy_dial_aws_endpoint branch 2 times, most recently from 0c5a72e to 4bb4737 Compare February 3, 2022 16:23
staebler
staebler reviewed Feb 3, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@rna-afk
aws: Use proxy dial to validate endpoints
048e009 
Using proxy dial instead of the current net dial for validating
service endpoints in AWS since there could be a proxy setup
when an IPI restricted installation occurs that might make the
the endpoints unreachable without using them.
@rna-afk rna-afk force-pushed the use_proxy_dial_aws_endpoint branch from 4bb4737 to 048e009 Compare February 3, 2022 16:42
@rna-afk rna-afk requested a review from staebler February 3, 2022 21:56
@staebler
Copy link
Contributor

staebler commented Feb 4, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-live-iso 048e009 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-single-node 048e009 link false /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel7 048e009 link false /test e2e-aws-workers-rhel7
ci/prow/okd-e2e-aws-upgrade 048e009 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-aws-workers-rhel8 048e009 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-crc 048e009 link false /test e2e-crc
ci/prow/e2e-ibmcloud 048e009 link false /test e2e-ibmcloud
ci/prow/e2e-azure-upi 048e009 link false /test e2e-azure-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8645de1 into openshift:master Feb 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

@rna-afk: All pull requests linked via external trackers have merged:

Bugzilla bug 2048451 has been moved to the MODIFIED state.

In response to this:

Bug 2048451: Use proxy dial to validate endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@staebler staebler Awaiting requested review from staebler

Assignees

@staebler staebler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rna-afk @staebler @openshift-bot @openshift-merge-robot