Have the MCO manage the ignition stub config

[runcom]

Completely WIP right now and won't even pass tests. I need this PR to further testing, launching clusters with openshift/machine-config-operator#1792

This turned out to be working with openshift/machine-config-operator#1792 - I'm now doing further testing and creating the enhancement to get the MCO PR in first and then this one

We need to change the name of the Secret so the MCO can recompute it with the very same name we're using. We need the naming change because when we upgrade, we want to leave the old worker|master-user-data around for old MachineSets to still use the old ignition types.

We need the installer to start using https://github.com/openshift/machine-config-operator/pull/1792/files#diff-5926e0cec606d949b66f823310790298R136 so we manage that snippet from the MCO as well.

Signed-off-by: Antonio Murdaca [email protected]

[runcom]

This would break UPI tho as we're not generating ignition configs anymore, will have to think more about this.

[runcom]

/retest

[runcom]

@abhinavdahiya @yuqi-zhang ptal - this is needed as the MCO counterpart has been merged already

[runcom]

/retest

[yuqi-zhang]

/retest

[yuqi-zhang]

I'm /approve on the change but 2 items:

1. are these two files the only location where we reference these secret names? Is any other UPI setup referencing these?
2. we'd also have to remember to update docs e.g. https://docs.openshift.com/container-platform/4.5/machine_management/creating_machinesets/creating-machineset-aws.html#machineset-yaml-aws_creating-machineset-aws to account for the change, since we're envisioning for ignition spec 3 we will no longer have master/worker-user-data (non-managed) at all

[runcom]

I'm /approve on the change but 2 items:

1. are these two files the only location where we reference these secret names? Is any other UPI setup referencing these?

I'm pretty sure that's what UPI consumes yeah, those I can only see when generating the manifests - @abhinavdahiya can you confirm?

2. we'd also have to remember to update docs e.g. https://docs.openshift.com/container-platform/4.5/machine_management/creating_machinesets/creating-machineset-aws.html#machineset-yaml-aws_creating-machineset-aws to account for the change, since we're envisioning for ignition spec 3 we will no longer have master/worker-user-data (non-managed) at all

ack, thx for pointing that out, I'll take an action on it

[runcom]

/retest

[runcom]

/assign abhinavdahiya

[abhinavdahiya]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yuqi-zhang]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[runcom]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@runcom: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-ovirt	8d278d2	link	/test e2e-ovirt
ci/prow/e2e-openstack	8d278d2	link	/test e2e-openstack
ci/prow/e2e-crc	8d278d2	link	/test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.