Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/*: re-order examples and make them consistent #255

Closed
wants to merge 1 commit into from

Conversation

eparis
Copy link
Member

@eparis eparis commented Sep 17, 2018

Put the things people MUST set at the top (admin, baseDomain, name,
pullSecret.) And things people probably don't care about at the bottom
(CA, nodepools). Remove some things we don't want people to touch
(some networking options and the iSCSI block)

Hopefully it's just a little easier to find and set what matters.

Put the things people MUST set at the top (admin, baseDomain, name,
pullSecret.) And things people probably don't care about at the bottom
(CA, nodepools). Remove some things we don't want people to touch
(some networking options and the iSCSI block)

Hopefully it's just a little easier to find and set what matters.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 17, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eparis
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveej

If they are not already assigned, you can assign the PR to them by writing /assign @steveej in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Sep 17, 2018

@crawford mentioned plans to switch to the next-gen asset framework (cmd/openshift-install) this week, which would replace these examples with InstallConfig instances. And I have InstallConfig support in flight for the old framework in #236. The InstallConfig format isn't that different from the old YAML format, so we may still want some re-ordering, but if we do I'd rather handle it in #236 or the PR that switches us to openshift-install, just to keep the number of balls in the air down ;). On the other hand, it would be straightforward enough to rebase around this PR if we do want to land it now. Thoughts?

@eparis
Copy link
Member Author

eparis commented Sep 17, 2018

less work for me to close this, and redo after we land the change.

@eparis eparis closed this Sep 17, 2018
@eparis eparis deleted the config-file-reorg branch February 18, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants