modules/bootkube/resources/bootkube: Restore --tmpfs #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
wking
force-pushed
the
restore-tmpdir
branch
2 times, most recently
from
a172263 to
c07eec9
Compare
Details on this build: $ curl -s http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/aws-us-east-1-tested.json | jq -S { "HVM": "ami-0af8953af3ec06b7c", "S3Object": "s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5595-aws.vmdk", "SnapshotID": "snap-07b2295a6b24ebf60" } $ curl -s http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/cloud/4.0.5595-1/meta.json | jq -S { "git-commit": "3863c9670d95ed950e5f68ca5e93947dfd214ef1", "image-genver": "1", "image-version": "4.0.5595-1", "ostree-commit": "622abd584071ebd426ff33b3d5b17cf08e16eff7d7fd2a9d97ace8ad24e3cedc", "ostree-version": "4.0.5595" } $ curl -s http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/cloud/4.0.5595-1/pkglist.txt | grep 'docker\|runc' docker-2:1.13.1-75.git8633870.el7_5.x86_64 docker-client-2:1.13.1-75.git8633870.el7_5.x86_64 docker-common-2:1.13.1-75.git8633870.el7_5.x86_64 docker-lvm-plugin-2:1.13.1-75.git8633870.el7_5.x86_64 docker-novolume-plugin-2:1.13.1-75.git8633870.el7_5.x86_64 docker-rhel-push-plugin-2:1.13.1-75.git8633870.el7_5.x86_64 runc-1.0.0-52.dev.git70ca035.el7_5.x86_64 After a brief window without either Docker or a working CRI-O, we've got a new RHCOS with Docker back on. Let's use it. This bump should also pull in runc-1.0.0-52.dev.git70ca035.el7_5.x86_64 needed by the next commit. Generated with: $ sed -i s/ami-07307c397daf4d02e/ami-0af8953af3ec06b7c/g $(git grep -l ami-07307c397daf4d02e)
We'd removed this in c234fc3 (*: use podman instead of docker, 2018-09-05, openshift#207) to work around [1,2]. Now that RHCOS is up to: $ curl -s http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/cloud/latest/pkglist.txt | grep runc runc-1.0.0-52.dev.git70ca035.el7_5.x86_64 we can restore the option. [1]: openshift/os#284 [2]: containers/podman#1396
wking
force-pushed
the
restore-tmpdir
branch
from
c07eec9 to
201fce4
Compare
|
/hold cancel This AMI should be good to go as far as Docker and runc are concerned. There's still an outstanding CRI-O bug in: $ curl -s http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/cloud/4.0.5595-1/pkglist.txt | grep 'cri-o'
cri-o-1.11.2-1.git3eac3b2.el7.x86_64The next image in the pipe has a bumped version: $ curl -s http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/cloud/4.0.5597-1/pkglist.txt | grep 'cri-o'
cri-o-1.11.3-2.rhaos3.11.git4fbb022.el7_5.x86_64But cri-o/cri-o#1796 is for 1.11.3-2, so we're still not out of the woods if we need this for #251 or similar. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The e2e-aws error was: @eparis just got the same thing over here. Did #119 break something here? |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
No. Do I need to? |
|
That helped #206 ; if this runs fails maybe then.. |
|
But it looks like CI is progressing correctly without it. 2018/09/15 01:45:27 Running pod e2e-aws
2018/09/15 02:00:30 Container setup in pod e2e-aws completed successfully
2018/09/15 02:01:12 Container test in pod e2e-aws completed successfully |
Yeah, I think test run after merging into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd removed this in c234fc3 (#207) to work around this and this. Now that RHCOS is up to:
we can restore the option.
/hold
We'll probably need to bump our AMI too...