kubelet: enable crio runtime #235
+3
−0
kubelet: enable crio runtime
commit 91cc901f6b994d8e2f431d107bc1710b696f6005
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -11,6 +11,9 @@ ExecStart=/usr/bin/hyperkube \ | ||
| --bootstrap-kubeconfig=/etc/kubernetes/kubeconfig \ | ||
| --kubeconfig=/var/lib/kubelet/kubeconfig \ | ||
| --rotate-certificates \ | ||
| --container-runtime=remote \ | ||
| --container-runtime-endpoint=unix:///var/run/crio/crio.sock \ | ||
| --runtime-request-timeout=10m \ | ||
|
There was a problem hiding this comment. Motivation for this setting is here. |
||
| --cni-conf-dir=/etc/kubernetes/cni/net.d \ | ||
| --cni-bin-dir=/var/lib/cni/bin \ | ||
| --network-plugin=cni \ | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also need to align with a change in the pod-checkpointer daemonset: https://github.com/kubernetes-incubator/bootkube/blob/master/cmd/checkpoint/main.go#L21
And if tests pass without this change - I'd be worried (and we should make sure checkpoint tests are actually running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I added the command line arg here.