*: remove support for container linux #221
Conversation
openshift-ci-robot
added
size/XL
For a structured approach to this, you may want to cherry-pick 9db8ed55 from #119 (or maybe I should PR it separately, since we could land it before openshift/release#1317?). |
| # chdir into the assets path directory | ||
| cd "$ASSETS_PATH/tectonic" | ||
| cd "tectonic" |
There was a problem hiding this comment.
Can we update the service file to launch this script in the asset directory? Then we could drop this cd entirely.
I'm not suggesting you pull in all of #119, just 9db8ed5. Then you could fallback to an AMI calculated by that (stub) package if the caller didn't set an override AMI in their config YAML. That gives us better forward compat, because callers can continue to not care which AMI gets used (while with your PR as it stands there will be a window when callers have to care and set a RHCOS AMI). |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
We currently calculate CoreOS Container Linux AMIs in Terraform
(installer/modules/aws/ami), but with the coming shift to RHCOS and Go
asset generation, it would be nice to calculate them in Go. This
commit adds a package to do so. Currently it's enough of a stub to
support testing, with the value based on [1]:
{
"HVM":"ami-06d864b4154214132",
"SnapshotID":"snap-07b63a4c2f8869c15",
"S3Object":"s3://openshift-qe-images/rhcos/cloud/rhcos-4.0.5122-aws.vmdk"
}
from [2]. Once we get a public version of [2] (plans in [3]), we can
replace the stub in this package with something that works for more
regions and channels.
[1]: openshift/release#1344 (comment)
[2]: http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/aws-us-east-1-tested.json
[3]: openshift/release#1344 (comment)
This drops a number of configuration options that are specific to Container Linux. This also changes the default region to us-east-1 throughout the tests.
is likely a flake, because /retest |
|
/lgtm |
|
/hold cancel openshift/release#1317 and related work are done. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since openshift/installer@66ef3beb (*: remove support for container linux, 2018-09-06, openshift/installer#221), the installer defaults to a recent RHCOS AMI. Drop the override here, so we can track RHCOS with only installer-repo bumps. I've left the variable in the template so that, if this repo needs to have its own, separate, opinion again, it can set the override again. However, to support the no-local-opinion case, the new local-opinion syntax will be: export EC2_AMI_OVERRIDE='ec2AMIOverride: ami-07307c397daf4d02e'
Catching up with 66ef3be (*: remove support for container linux, 2018-09-06, openshift#221).
This drops a number of configuration options that are specific to
Container Linux. This also changes the default region to us-east-1
throughout the tests.