Update UPI vSphere terraform code for v0.12 #2057

DanyC97 · 2019-07-22T15:00:39Z

This PR updates the UPI vSphere terraform templates to v0.12.

Ref #1936 (comment)

@abhinavdahiya @staebler @vrutkovs please help review it.

openshift-ci-robot · 2019-07-22T15:00:53Z

Hi @DanyC97. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-07-22T15:01:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanyC97
To complete the pull request process, please assign staebler
You can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

upi/vsphere/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrutkovs · 2019-07-22T15:06:29Z

upi/vsphere/README.md


-5. Ensure that you have you AWS profile set and a region specified. The installation will use create AWS route53 resources for routing to the OpenShift cluster.


Route53 is still being used for DNS, isn't it?

that is correct @vrutkovs is still used hence why i've moved it up in the pre-req section so folks know upfront what is required from the existing code base.

I can extend if y'all okay with to mention why R53 provider is used and not DNS provider, let me know

vrutkovs · 2019-07-22T15:09:10Z

/test e2e-vsphere

vrutkovs · 2019-07-22T15:09:18Z

/ok-to-test

DanyC97 · 2019-07-22T15:30:31Z

job failed due to

govc: Post https://vcsa-ci.vmware.devcluster.openshift.com/sdk: dial tcp 139.178.73.3:443: i/o timeout
2019/07/22 15:21:01 Container setup in pod e2e-vsphere failed, exit code 1, reason Error

sounds like you not able to import the template into your vCenter env

abhinavdahiya · 2019-07-22T16:17:36Z

/hold

we are close (almost in) feature freeze, cannot make these changes until there's an exception.

DanyC97 · 2019-07-22T17:07:41Z

/hold

we are close (almost in) feature freeze, cannot make these changes until there's an exception.

no problem at all, totally understand ! let me know when you are out the freeze mode, happy to carry on from there

fherbert · 2019-08-21T07:05:20Z

upi/vsphere/main.tf

-  path          = "${var.cluster_id}"
-  datacenter_id = "${data.vsphere_datacenter.dc.id}"
+  //path          = "${var.cluster_id}"
+  path          = "Dani/${var.vm_folder}"


Is 'Dani/' prepended to the folder path why the tests fail? You probably don't want this included in the PR?

thanks @fherbert , fixed

fherbert · 2019-08-21T07:12:07Z

upi/vsphere/route53/main.tf

 }

 resource "aws_route53_record" "control_plane_nodes" {
-  count = "${var.control_plane_count}"
+  count = var.control_plane_count}


need to remove this trailing '}'

thanks @fherbert , fixed

DanyC97 · 2019-09-24T10:27:52Z

@abhinavdahiya i saw you started to work on #2396 , can i assume we can re-activate this PR ?

DanyC97 · 2019-10-19T12:43:05Z

@abhinavdahiya gentle reminder, please let me know if you are still interested in this PR now that 4.2 is out.

If not then please close this PR.

mkelnermishal · 2019-11-11T14:00:29Z

Hey,
Is there any update on this code ? we need it in order to release 4.2 to our customers (VMware).
Thanks.

DanyC97 · 2019-11-11T23:49:53Z

Hey,
Is there any update on this code ? we need it in order to release 4.2 to our customers (VMware).
Thanks.

@mkelnermishal happy to continue the work if @abhinavdahiya confirm he is ready/ happy to accept the PR, haven't received any feedback on my previous attempts to get an answer hence my assumption is that is not needed

abhinavdahiya · 2019-11-22T23:03:31Z

/test e2e-vsphere

openshift-ci-robot · 2019-11-22T23:03:37Z

@DanyC97: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhinavdahiya · 2019-11-22T23:06:05Z

Thanks for the changes! And I think it's important that we move to 0.12 terraform..

So here's the pickle, the baremetal using packet.net here also uses the terraform..

and the image we use to test both is 0.11

installer/images/installer/Dockerfile.upi.ci

Line 29 in 9dcd4d2

ENV TERRAFORM_VERSION=0.11.11

so we will have to either make sure:
A) update the CI image used for terraform to 0.12, make sure baremetal has terraform version set to <=0.11 i think that should allow 0.12 terraform binary to run in 0.11 mode and then we can merge this change.

B) we update all the changes in one PR.

DanyC97 · 2019-11-23T18:14:07Z

A) update the CI image used for terraform to 0.12, make sure baremetal has terraform version set to <=0.11 i think that should allow 0.12 terraform binary to run in 0.11 mode and then we can merge this change.

B) we update all the changes in one PR.

@abhinavdahiya thank you for taking the time to respond and refocus attention on this PR. I'm easy going with either of the 2 suggestions.

What does the baremetal team prefer to go with?

DanyC97 · 2019-11-23T18:24:08Z

maybe merge the effort in one PR with #2479 or chain them one after another or just be aware of it ;)

abhinavdahiya · 2019-12-10T23:01:48Z

A) update the CI image used for terraform to 0.12, make sure baremetal has terraform version set to <=0.11 i think that should allow 0.12 terraform binary to run in 0.11 mode and then we can merge this change.
B) we update all the changes in one PR.

@abhinavdahiya thank you for taking the time to respond and refocus attention on this PR. I'm easy going with either of the 2 suggestions.

What does the baremetal team prefer to go with?

I would prefer the option B. if you can help migrate the metal work with vsphere work to 0.12. I can help review and get it merged...

openshift-ci-robot · 2020-01-31T01:45:46Z

@DanyC97: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`f3b6f8c`	link	`/test e2e-aws-scaleup-rhel7`
ci/prow/e2e-aws-disruptive	`f3b6f8c`	link	`/test e2e-aws-disruptive`
ci/prow/e2e-vsphere	`f3b6f8c`	link	`/test e2e-vsphere`
ci/prow/tf-lint	`f3b6f8c`	link	`/test tf-lint`
ci/prow/shellcheck	`f3b6f8c`	link	`/test shellcheck`
ci/prow/yaml-lint	`f3b6f8c`	link	`/test yaml-lint`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

DanyC97 · 2020-04-13T10:49:08Z

closing in favour of #3235 and #3429

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2019

openshift-ci-robot requested review from jcpowermac and mtnbikenc July 22, 2019 15:01

vrutkovs reviewed Jul 22, 2019

View reviewed changes

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019

This was referenced Aug 9, 2019

Vsphere terraform deployment fail #2183

Closed

Updating main.tf for terraform version 0.12 #2185

Closed

fherbert reviewed Aug 21, 2019

View reviewed changes

Update UPI vSphere terraform code for v0.12

f3b6f8c

DanyC97 force-pushed the vsphere-upi-tf-012 branch from 628ec2f to f3b6f8c Compare August 24, 2019 15:11

DanyC97 mentioned this pull request Aug 24, 2019

initializing terraform for vSphere UPI fails with latest terraform version #2260

Closed

wking mentioned this pull request Sep 18, 2019

Bug 1753032: cluster-launch-installer-upi-e2e: vsphere upi: Add bootstrap gather openshift/release#5060

Merged

DanyC97 mentioned this pull request Nov 12, 2019

OpenShift on VMware Cloud on AWS #2603

Closed

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2019

vrutkovs mentioned this pull request Jan 20, 2020

WIP [FCOS] vSphere: update UPI files to tf 1.12 #2953

Merged

2 tasks

abhinavdahiya added the version/4.5 label Feb 10, 2020

DanyC97 closed this Apr 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UPI vSphere terraform code for v0.12 #2057

Update UPI vSphere terraform code for v0.12 #2057

DanyC97 commented Jul 22, 2019

openshift-ci-robot commented Jul 22, 2019

openshift-ci-robot commented Jul 22, 2019

vrutkovs Jul 22, 2019

DanyC97 Jul 22, 2019

vrutkovs commented Jul 22, 2019

vrutkovs commented Jul 22, 2019

DanyC97 commented Jul 22, 2019

abhinavdahiya commented Jul 22, 2019

DanyC97 commented Jul 22, 2019 •

edited

Loading

fherbert Aug 21, 2019

DanyC97 Aug 24, 2019

fherbert Aug 21, 2019

DanyC97 Aug 24, 2019

DanyC97 commented Sep 24, 2019

DanyC97 commented Oct 19, 2019

mkelnermishal commented Nov 11, 2019

DanyC97 commented Nov 11, 2019

abhinavdahiya commented Nov 22, 2019

openshift-ci-robot commented Nov 22, 2019

abhinavdahiya commented Nov 22, 2019 •

edited

Loading

DanyC97 commented Nov 23, 2019

DanyC97 commented Nov 23, 2019

abhinavdahiya commented Dec 10, 2019

openshift-ci-robot commented Jan 31, 2020

DanyC97 commented Apr 13, 2020


		5. Ensure that you have you AWS profile set and a region specified. The installation will use create AWS route53 resources for routing to the OpenShift cluster.

Update UPI vSphere terraform code for v0.12 #2057

Update UPI vSphere terraform code for v0.12 #2057

Conversation

DanyC97 commented Jul 22, 2019

openshift-ci-robot commented Jul 22, 2019

openshift-ci-robot commented Jul 22, 2019

vrutkovs Jul 22, 2019

Choose a reason for hiding this comment

DanyC97 Jul 22, 2019

Choose a reason for hiding this comment

vrutkovs commented Jul 22, 2019

vrutkovs commented Jul 22, 2019

DanyC97 commented Jul 22, 2019

abhinavdahiya commented Jul 22, 2019

DanyC97 commented Jul 22, 2019 • edited Loading

fherbert Aug 21, 2019

Choose a reason for hiding this comment

DanyC97 Aug 24, 2019

Choose a reason for hiding this comment

fherbert Aug 21, 2019

Choose a reason for hiding this comment

DanyC97 Aug 24, 2019

Choose a reason for hiding this comment

DanyC97 commented Sep 24, 2019

DanyC97 commented Oct 19, 2019

mkelnermishal commented Nov 11, 2019

DanyC97 commented Nov 11, 2019

abhinavdahiya commented Nov 22, 2019

openshift-ci-robot commented Nov 22, 2019

abhinavdahiya commented Nov 22, 2019 • edited Loading

DanyC97 commented Nov 23, 2019

DanyC97 commented Nov 23, 2019

abhinavdahiya commented Dec 10, 2019

openshift-ci-robot commented Jan 31, 2020

DanyC97 commented Apr 13, 2020

DanyC97 commented Jul 22, 2019 •

edited

Loading

abhinavdahiya commented Nov 22, 2019 •

edited

Loading