asset/precluster: pre-cluster stage #1532
Conversation
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
$ openshift-install create node-config
INFO Consuming "Install Config" from target directory
$ tree
.
├── master.ign
└── worker.ign
0 directories, 2 files
$ openshift-install create bootstrap-config
INFO Consuming "Master Ignition Config" from target directory
INFO Consuming "Worker Ignition Config" from target directory
$ tree
.
└── bootstrap.ign
0 directories, 1 file
$ openshift-install create pre-cluster
INFO Consuming "Bootstrap Ignition Config" from target directory
$ tree
.
└── pre-cluster
├── auth
│ ├── kubeadmin-password
│ └── kubeconfig
├── bootstrap.ign
├── master.ign
├── metadata.json
└── worker.ign
2 directories, 6 files |
@abhinavdahiya Sure. I can. This PR won't work without those two commits, though, so I would still keep them in this PR. Do you have specific concerns about the individual commits where you think some of them may be acceptable and others not? |
I'm hoping we can fix the metadata and missing kubeadmin issue in existing setup before we decide on using the |
|
On further analysis, the issue addressed by 21b631a8d74c59cec4fe55c82512c9a33ad88900 is not a problem in master. The metadata.json file is not created when |
|
Also, the kubeadmin-password file only needs to be created by the Kubeadmin Password asset instead of the Cluster asset so that it can also be created by the |
Add an installer command to create a pre-cluster asset. This asset includes read-only copies of assets that are useful prior to creating a cluster. * bootstrap ignition * master ignition * worker ignition * metadata.json * kubeconfig * kube admin password The files are created in a pre-cluster directory under the assets directory. The pre-cluster stage is a replacement for the node-configs stage, which had collected more targeted assets than just node configs. The old stage has been retained but deprecated. A bootstrap-config stage has been added which targets just the bootstrap ignition. A node-config stage has been added which targets just the master and worker ignitionds. Fixes https://jira.coreos.com/browse/CORS-948
Regenerate the asset graph to capture the bootstrap-config and pre-cluster stages. $ dot -V dot - graphviz version 2.40.1 (20161225.0304)
The ignition-configs stage has been deprecated and replaced with the node-config, bootstrap-config, and pre-cluster stages. The docs are updated to reflect those changes.
|
@staebler: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
@staebler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
closing due to inactivity. Please reopen if needed. /close |
|
@abhinavdahiya: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add an installer command to create a pre-cluster asset. This asset includes read-only copies of assets that are useful prior to creating a cluster.
The files are created in a pre-cluster directory under the assets directory.
The pre-cluster stage is a replacement for the node-configs stage, which had collected more targeted assets than just node configs. The old stage has been retained but deprecated.
A bootstrap-config stage has also been added which targets just the bootstrap ignition.
A bootstrap-config stage has been added which targets just the bootstrap ignition. A node-config stage has been added which targets just the master and worker ignitions.
Fixes https://jira.coreos.com/browse/CORS-948