Skip to content

Commit

Permalink
vsphere: Close a possible race with Ignition firstboot completion
Browse files Browse the repository at this point in the history
I was looking at https://bugzilla.redhat.com/show_bug.cgi?id=1762509
and that linked to this code (I don't quite understand why
we're rebooting here...this code really needs like some comments)
but anyways one possible issue I see here is that we will
race with `ignition-firstboot-complete.service`.

I'm going to fix FCOS so that service runs much earlier too,
but let's add this ordering here.

And someone please explain in some comments what is going on
here.
  • Loading branch information
cgwalters committed Oct 23, 2019
1 parent 1c32be0 commit dc9889c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions upi/vsphere/machine/ignition.tf
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ data "ignition_systemd_unit" "restart" {
content = <<EOF
[Unit]
ConditionFirstBoot=yes
After=ignition-firstboot-complete.service
[Service]
Type=idle
ExecStart=/sbin/reboot
Expand Down

0 comments on commit dc9889c

Please sign in to comment.